-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragging View issue #29
Comments
I am having this exact same issue. Since this issue makes the library almost useless (it happens like 1 out of 3 times), would it be possible to fix this issue? I'd love to dig into the code and fix it myself, but I have no clue where to look.. Thanks a lot for the awesome library though! |
@brammahh Can you upload your project so I can checkout how you have implemented. I am not seeing this in the example project. |
In attachement, you can find my project. After clicking 'Start app', you can drag left and right for the menu's to appear. If you drag them fast enough one after the other, the app freezes from time to time. Thanks in advance! |
I have the exact same problem as you. I can't seem to find a good way to reproduce it, but I happens often enough to make the app unsubmitable. |
I will reimplement this lib as as Hero plugin once Hero supports overFullScreen presentation. That would help eliminate these bugs and make it support navigationController. For now I don't have a work around. |
@lkzhao cool, thank you for the swift reply. Unfortunately, I'm not skilled enough to give any valuable input. It's just too bad I really like this transition and build my app around, but might need to find something else. |
I found that was because the animation completion block not been called, if dragging too fast or too often, and then transition did no clean works. |
@lkzhao Any chance you can look into this again? This issue has been around for more than a year now. |
If this helps I think i've identified the issue and the fix:
|
@mrdavidrees I used your code and totally worked! Thanks |
@lkzhao: Did you implement Elastic Transition is a part of Hero? I download it but no find Elastic mode in it. |
I agree |
Sometimes when dragging a view (presenting and dismissing), the app "freezes" and we can't navigate to other views.
The text was updated successfully, but these errors were encountered: