Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Impressive #4

Open
ghost opened this issue Dec 23, 2017 · 14 comments
Open

Impressive #4

ghost opened this issue Dec 23, 2017 · 14 comments

Comments

@ghost
Copy link

ghost commented Dec 23, 2017

This is very impressive widget.

The format that the data is saved in is similar to quill perhaps. Is it json by any chance.

Looking to help extend this and am thinking that the quill format is a nice way to do it.

You know quill ?

@long1eu
Copy link
Owner

long1eu commented Dec 23, 2017 via email

@ghost
Copy link
Author

ghost commented Dec 23, 2017 via email

@long1eu
Copy link
Owner

long1eu commented Dec 23, 2017 via email

@long1eu
Copy link
Owner

long1eu commented Dec 28, 2017

ok, so who are going to port this library to Flutter? what's your plan?

@ghost
Copy link
Author

ghost commented Dec 28, 2017

Right now i have to chicken out. Just no bandwidth.

I used y.js witha web / javascript client on an old project and it worked really well with quill.
This is why i brouht it up.

here is another one btw:
https://github.com/ipfs-shipyard/peerpad/blob/master/docs/ARCHITECTURE.md

@ghost
Copy link
Author

ghost commented Apr 20, 2018

Hey again,

I have been doing some research on this and have a MUCH better approach now.

There is a library called automerge.
It is able to take json and keep it in sync between multiple instances on different devices. It's based on CRDT and works very well.
The maintainers are talking about making a port to Dart, but it's not started yet. It should be a reasonable easy port.

So the only thing then that matters is how you serialise the HTML widget to JSON. I suspect you won't need to do anything special but I am not sure yet until I do more testing.

@ghost
Copy link
Author

ghost commented Apr 20, 2018

In your code I don't see any code that serialises the contents of the widget....
You never got to the functionality of saving and loading content to and from json ?

@long1eu
Copy link
Owner

long1eu commented Apr 20, 2018

hi!

No I don't do that for now. The thing here is that I don't really want to use and html conversion approach. I'm still thinking on this. Anyways this lib is old and I didn't have time to maintain it. I think that I would need to take a different approach on building this too.

@long1eu long1eu closed this as completed Apr 20, 2018
@long1eu long1eu reopened this Apr 20, 2018
@ghost
Copy link
Author

ghost commented Apr 20, 2018

appreciate your comments.
Yours is the only one i have found, and if you can illustrate how you would rewrite it then maybe me or someone will do it.
Is that ok ?

@long1eu
Copy link
Owner

long1eu commented Apr 21, 2018 via email

@ghost
Copy link
Author

ghost commented Apr 22, 2018 via email

@long1eu
Copy link
Owner

long1eu commented Apr 22, 2018

not at all

@ghost
Copy link
Author

ghost commented Apr 22, 2018 via email

@shenmashi
Copy link

compiler message: file:///Users/shenma/Documents/Flutter/projects/rich_editor/rich_editor/lib/src/material/dropdown.dart:267:7: Error: The non-abstract class '_DropdownRoute' is missing implementations for these members:
compiler message: 'barrierLabel'.
compiler message: Try to either
compiler message: - provide an implementation,
compiler message: - inherit an implementation from a superclass or mixin,
compiler message: - mark the class as abstract, or
compiler message: - provide a 'noSuchMethod' implementation.
compiler message:
compiler message: class _DropdownRoute extends PopupRoute<_DropdownRouteResult> {
compiler message: ^^^^^^^^^^^^^^
compiler message: file:///Users/shenma/Documents/Flutter/flutter/packages/flutter/lib/src/widgets/routes.dart:831:14: Context: 'barrierLabel' is defined here.
compiler message: String get barrierLabel;
compiler message: ^^^^^^^^^^^^
compiler message: file:///Users/shenma/.pub-cache/hosted/pub.dartlang.org/material_color_picker-0.0.1/lib/src/dropdown.dart:33:7: Error: The non-abstract class '_WidgetDropdownRoute' is missing implementations for these members:
compiler message: 'barrierLabel'.
compiler message: Try to either
compiler message: - provide an implementation,
compiler message: - inherit an implementation from a superclass or mixin,
compiler message: - mark the class as abstract, or
compiler message: - provide a 'noSuchMethod' implementation.
compiler message:
compiler message: class _WidgetDropdownRoute extends PopupRoute {
compiler message: ^^^^^^^^^^^^^^^^^^^^
compiler message: file:///Users/shenma/Documents/Flutter/flutter/packages/flutter/lib/src/widgets/routes.dart:831:14: Context: 'barrierLabel' is defined here.
compiler message: String get barrierLabel;
compiler message: ^^^^^^^^^^^^
compiler message: file:///Users/shenma/Documents/Flutter/projects/rich_editor/rich_editor/lib/src/widgets/rich_editable_text.dart:873:18: Error: Too many positional arguments: 0 allowed, 1 given.
compiler message: renderObject.setCaretPrototype(currentStyle.fontSize);
compiler message: ^
Compiler failed on /Users/shenma/Documents/Flutter/projects/rich_editor/rich_editor_demo/lib/main.dart

FAILURE: Build failed with an exception.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants