Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add division function longr #62

Open
6 tasks
longr opened this issue Mar 9, 2023 · 0 comments
Open
6 tasks

[FEATURE] Add division function longr #62

longr opened this issue Mar 9, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@longr
Copy link
Owner

longr commented Mar 9, 2023

Use this checklist to tick off sub-tasks as you complete them:

  • Create new <username>_divide branch
  • Add divide function
  • Add divide test
  • Commit changes and push to GitHub
  • Make pull request
  • Close issue

Instructions

Create branch

Create a new <username>_divide branch from main to work in.

Add division function

Create a new <username>_divide.py file in the pythoncalculator/ directory.

def divide(x, z):
    return x / y

Add division test

Create a new test_<username>_divide.py file in the tests/ directory.

Add the following code and save:

from pythoncalculator.<username>_divide import divide


def test_divide():
    assert divide(10, 2) == 5

Commit your changes and push to GitHub

Once you've created your function and test files commit your changes.

Use resolves #{ISSUE_NUMBER_YOU_WERE_ASSIGNED} in your commit message to automatically close the issue when your pull request is merged.

Then push them up to GitHub

Create pull request

Finally, create a pull request back to the main branch on GitHub and wait for the owner's review.

Reference the issue your pull request refers to with #{ISSUE_NUMBER_YOU_WERE_ASSIGNED} in the description.

Respond to any requests for correction.

Close issue

If the issue didn't close automatically, close it yourself. You can also

@longr longr added enhancement New feature or request help wanted Extra attention is needed labels Mar 9, 2023
@longr longr self-assigned this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant