Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add multiplication function mattjbr123 #64

Open
6 tasks
mattjbr123 opened this issue Mar 9, 2023 · 0 comments
Open
6 tasks

[FEATURE] Add multiplication function mattjbr123 #64

mattjbr123 opened this issue Mar 9, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mattjbr123
Copy link
Collaborator

mattjbr123 commented Mar 9, 2023

Use this checklist to tick off sub-tasks as you complete them following these:

  • Create new <username>_multiply branch
  • Add multiply function
  • Add multiply test
  • Commit changes and push to GitHub
  • Make pull request
  • Close issue

Instructions

Create branch

Create a new <username>_multiply branch from main to work in.

Hint: git checkout -b <branch name>

Add multiplication function

Create a new <username>_multiply.py file in the pythoncalculator/ directory.

def multiply(x, y):
    return x + y

Add multiplication test

Create a new test_<username>_multiply.py file in the tests/ directory.

Add the following code and save:

from pythoncalculator.<username>_multiply import multiply


def test_multiply():
    assert multiply(10, 3) == 30

Commit your changes and push to GitHub

Once you've created your function and test files, commit your changes.

Use resolves #{ISSUE_NUMBER_YOU_WERE_ASSIGNED} in your commit message to automatically close the issue when your pull request is merged.

Then push them up to GitHub

Create pull request

Finally, create a pull request back to the main branch on GitHub and wait for the owner's review.

Reference the issue your pull request refers to with #{ISSUE_NUMBER_YOU_WERE_ASSIGNED} in the description.

Respond to any requests for correction.

Close issue

If the issue didn't close automatically, close it yourself. You can also

@mattjbr123 mattjbr123 added enhancement New feature or request help wanted Extra attention is needed labels Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants