Remove PR trigger from template GH action workflow

[kbjarkefur]

adodown/src/ado/templates/ad-build_adodown_site.yaml

Lines 1 to 5 in 4e9ab12

	on:
	push:
	branches: [main, master]
	pull_request:
	branches: [main, master]

I suggest changing this to:

 on: 
   push: 
     branches: [main, master] 

A merge of a PR is considered a push. So the action will be triggered when a PR is merged to main/master.

Otherwise the action will be triggered when a PR towards main/master is opened, and when a branch with an open PR towards main/master is updated. While technically not an issue, it is redundant, as in those cases nothing has changed on main/master where the action reads to, so it will never lead to any changes on the gh-pages branch. Since GH actions are free on public repos, this is not an issue in most cases, but if, for example, the build fails, you will get an error notification each time you update an open PR.

So all-in-all, I would say it is cleaner to not have a trigger for PRs. What do you think @arthur-shaw ?

[kbjarkefur]

If we agree to remove this, then I guess we should also remove this line:

adodown/src/ado/templates/ad-build_adodown_site.yaml

Line 67 in 4e9ab12

if: github.event_name != 'pull_request'

[kbjarkefur]

Done in f77d898

Note the file was also renamed in that commit.

Leaving this issue open until our team has decided that this is what we will do.