From 0eea441c9387adc994e2e11489783498a19ab0ba Mon Sep 17 00:00:00 2001 From: tajo Date: Sat, 12 Mar 2016 21:56:41 -0500 Subject: [PATCH] click outside did not close the portal in some cases because HTML tagname was ignored, that was because we tried to prevent closing when scrollbar was clicked, however this is a bigger issue... if you know about some workaround for ignoring scrollbar, let me know --- lib/portal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/portal.js b/lib/portal.js index 7a6ce5f..6a3eaf3 100644 --- a/lib/portal.js +++ b/lib/portal.js @@ -136,7 +136,7 @@ export default class Portal extends React.Component { if (!this.state.active) { return; } const root = findDOMNode(this.portal); - if (root.contains(e.target) || e.target.tagName === 'HTML' || e.button !== 0) { return; } + if (root.contains(e.target) || e.button !== 0) { return; } e.stopPropagation(); this.closePortal();