Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ContinuousTransformerWrapper needed? #284

Open
mpeven opened this issue Oct 28, 2024 · 2 comments
Open

Is ContinuousTransformerWrapper needed? #284

mpeven opened this issue Oct 28, 2024 · 2 comments

Comments

@mpeven
Copy link
Contributor

mpeven commented Oct 28, 2024

Maybe I'm missing something, just wondering if ContinuousTransformerWrapper is just an instance of TransformerWrapper like this:

class ContinuousTransformerWrapper(TransformerWrapper):
    def __init__(self, in_dim, emb_dim, out_dim, **kwargs):
        super().__init__(
            num_tokens=0,
            token_emb=torch.nn.Identity() if in_dim == emb_dim else torch.nn.Linear(in_dim, emb_dim, bias=False),
            logits_dim=out_dim,
            **kwargs
        )
@lucidrains
Copy link
Owner

lucidrains commented Oct 29, 2024

@mpeven yes indeed, with a mse loss in its autoregressive wrapper

it started off pretty simple, but then people wanted more and more features from the discrete transformerwrapper

maybe a merging is overdue

@lucidrains
Copy link
Owner

@mpeven in the beginning, i was also expecting a lot more diverging research, but it hasn't panned out that way

if anything i think the new practice may be to add denoising diffusion heads (which warrants a complete new wrapper)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants