From 0b97f64545052d5e4e0509cd9684d30bc3dd2843 Mon Sep 17 00:00:00 2001
From: George Zhao <zhaozg@gmail.com>
Date: Fri, 26 May 2023 22:42:29 +0800
Subject: [PATCH] add tests about crash issues

---
 tests/manual-test-exit.lua           | 22 +++++++++++
 tests/manual-test-without-uv.run.lua |  4 ++
 tests/test-loop.lua                  | 57 ++++++++++++++++++++++++++++
 3 files changed, 83 insertions(+)
 create mode 100644 tests/manual-test-exit.lua
 create mode 100644 tests/manual-test-without-uv.run.lua

diff --git a/tests/manual-test-exit.lua b/tests/manual-test-exit.lua
new file mode 100644
index 00000000..39db7e6d
--- /dev/null
+++ b/tests/manual-test-exit.lua
@@ -0,0 +1,22 @@
+--come from https://github.com/luvit/luv/issues/599
+
+-- run `lua manual-test-exit.lua || echo $?`
+-- it shoud print `5`
+
+local uv = require('luv')
+
+local function setTimeout(callback, ms)
+    local timer = uv.new_timer()
+    timer:start(ms, 0, function()
+        timer:stop()
+        timer:close()
+        callback()
+    end)
+    return timer
+end
+
+setTimeout(function()
+    os.exit(5, true)
+end, 1000)
+
+uv.run()
diff --git a/tests/manual-test-without-uv.run.lua b/tests/manual-test-without-uv.run.lua
new file mode 100644
index 00000000..c205888d
--- /dev/null
+++ b/tests/manual-test-without-uv.run.lua
@@ -0,0 +1,4 @@
+local uv = require('luv')
+
+local test = uv.new_pipe(false)
+uv.close(test)
diff --git a/tests/test-loop.lua b/tests/test-loop.lua
index f0a4504c..cfe64b79 100644
--- a/tests/test-loop.lua
+++ b/tests/test-loop.lua
@@ -1,5 +1,18 @@
 return require('lib/tap')(function (test)
 
+  local function get_cmd()
+    local i=1
+    repeat
+      i=i-1
+    until not arg[i]
+    return arg[i+1]
+  end
+
+  local cmd = get_cmd()
+  local cwd = require('luv').cwd()
+  print("cmd: ", cmd)
+  print("cwd: ", cwd)
+
 	test("uv.loop_mode", function (print, p, expect, uv)
 		assert(uv.loop_mode() == nil)
     local timer = uv.new_timer()
@@ -10,4 +23,48 @@ return require('lib/tap')(function (test)
     end))
   end)
 
+  test("issue #437, crash without uv.run", function (print, p, expect, uv)
+    local handle
+    local stdout = uv.new_pipe(false)
+
+    handle = uv.spawn(cmd, {
+      args = { "tests/manual-test-without-uv.run.lua" },
+      cwd = cwd,
+      stdio = {nil, stdout},
+    },
+    expect(function(status, signal)
+      print('#437', status, signal)
+      assert(status==0)
+      assert(signal==0)
+      handle:close()
+    end))
+
+    uv.read_start(stdout, expect(function (err, chunk)
+      p("stdout", {err=err,chunk=chunk})
+      uv.close(stdout)
+    end))
+  end)
+
+  test("issue #599, crash during calling os.exit", function (print, p, expect, uv)
+    local handle
+    local stdout = uv.new_pipe(false)
+
+    handle = uv.spawn(cmd, {
+      args = { "tests/manual-test-exit.lua" },
+      cwd = cwd,
+      stdio = {nil, stdout},
+    },
+    expect(function(status, signal)
+      print('#599', status, signal)
+      assert(status==5)
+      assert(signal==0)
+      handle:close()
+    end))
+
+    uv.read_start(stdout, expect(function (err, chunk)
+      p("stdout", {err=err,chunk=chunk})
+      uv.close(stdout)
+    end))
+  end)
+
 end)