Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AspectFit and Aspect Fill mode don't work properly when using Zoomy intazoom mode #62

Closed
bizibizi opened this issue Feb 12, 2019 · 4 comments
Assignees
Labels
bug Something isn't working (correctly) roadmap will be implemented soon
Milestone

Comments

@bizibizi
Copy link

bizibizi commented Feb 12, 2019

It;s crashing all UI basically. Can you check it please?

@bizibizi
Copy link
Author

i am using those methids as well

extension YourViewController: Zoomy.Delegate {

func didBeginPresentingOverlay(for imageView: UIImageView) {
    scrollView.isScrollEnabled = false
}

func didEndPresentingOverlay(for imageView: UIImageView) {
    scrollView.isScrollEnabled = true
}

}

@bizibizi bizibizi changed the title works very bad in CollectionView works very bad in CollectionView for imageView with AspectFit mode Feb 12, 2019
@bizibizi
Copy link
Author

well, i solved that with https://github.com/ergunemr/EEZoomableImageView

@lvnkmn
Copy link
Owner

lvnkmn commented Mar 11, 2019

Glad you have been able to fix this in your code. This is a known issue indeed. Currently Zoomy doesn't have full support for all content modes and works best when the aspect ratio of the image and the aspect ratio of the image view it's displayed in stay the same.

@lvnkmn
Copy link
Owner

lvnkmn commented Jul 30, 2019

@bizibizi I've found some time and will pick this issue up. Since I see you have been dealing with this in the insta zoom mode, I will first solve it in this mode (and later for the scroll based mode in #67)

@lvnkmn lvnkmn changed the title works very bad in CollectionView for imageView with AspectFit mode AspectFit and Aspect Fill mode don't work properly when using Zoomy intazoom mode Jul 30, 2019
@lvnkmn lvnkmn self-assigned this Jul 30, 2019
@lvnkmn lvnkmn added bug Something isn't working (correctly) roadmap will be implemented soon labels Jul 30, 2019
@lvnkmn lvnkmn added this to the 2.0.1 milestone Jul 30, 2019
@lvnkmn lvnkmn closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (correctly) roadmap will be implemented soon
Projects
None yet
Development

No branches or pull requests

2 participants