From 207c7af61de248826dbb3542e079676a903ded05 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lu=C3=ADs=20Pereira?= Date: Wed, 8 May 2024 21:46:47 +0100 Subject: [PATCH] Obsolete (#1121) * Drop application desktop file name suffix The documentation states that the file name, without the full path or the trailing ".desktop" extension. Avoids a runtime warning. * Drop QVariant obsolete methods --- src/main.cpp | 2 +- src/tabwidget.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index d094757b..c0d020de 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -134,7 +134,7 @@ int main(int argc, char *argv[]) QApplication::setApplicationName(QStringLiteral("qterminal")); QApplication::setApplicationVersion(QStringLiteral(QTERMINAL_VERSION)); QApplication::setOrganizationDomain(QStringLiteral("qterminal.org")); - QApplication::setDesktopFileName(QLatin1String("qterminal.desktop")); + QApplication::setDesktopFileName(QLatin1String("qterminal")); // Warning: do not change settings format. It can screw bookmarks later. QSettings::setDefaultFormat(QSettings::IniFormat); diff --git a/src/tabwidget.cpp b/src/tabwidget.cpp index 213df2ed..11373d33 100644 --- a/src/tabwidget.cpp +++ b/src/tabwidget.cpp @@ -315,7 +315,7 @@ void TabWidget::removeFinished() { QObject* term = sender(); QVariant prop = term->property(TAB_INDEX_PROPERTY); - if(prop.isValid() && prop.canConvert(QVariant::Int)) + if(prop.isValid() && prop.canConvert()) { int index = prop.toInt(); removeTab(index);