Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does exclude_path support regular expressions? #1608

Open
trask opened this issue Jan 8, 2025 · 2 comments
Open

Does exclude_path support regular expressions? #1608

trask opened this issue Jan 8, 2025 · 2 comments
Labels
bug Something isn't working docs Improvements or additions to documentation

Comments

@trask
Copy link
Contributor

trask commented Jan 8, 2025

The docs (https://lychee.cli.rs/recipes/excluding-paths) seem to indicate that it does

Regular expressions are also supported.
...
exclude_path = ["node_modules", "^./dir/", "./dev/."]

but I can't get it to work, and I don't see any tests in the repo for it, thanks.

@mre
Copy link
Member

mre commented Jan 9, 2025

Nope, it doesn't. It's a PathBuf:

pub(crate) exclude_path: Vec<PathBuf>,

I thought it did, but no dice.
Although we could certainly make it accept a regex and we probably should. Would you like to tackle that?
Then I don't have to adjust the docs. 🤣

@mre mre added bug Something isn't working docs Improvements or additions to documentation labels Jan 9, 2025
@trask
Copy link
Contributor Author

trask commented Jan 9, 2025

I didn't end up needing the behavior, so just reporting doc bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants