Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024_07: BUG Github Actions - Failed Checks and GH-Pages Deployment Not Working for Updating Team PSD Manual #3222

Closed
lijenn opened this issue Jul 20, 2024 · 10 comments
Assignees
Labels
bug These are problems associated with technologies that need to be fixed right away. Development Value stream activities in support of technological development.
Milestone

Comments

@lijenn
Copy link
Collaborator

lijenn commented Jul 20, 2024

@matomasz to assess with @tejaspesquare.

@lijenn was trying to fix broken images mentioned in research/#550 brought up @lzim and @retooler, but encountered these failed Action Checkers in the pull request:
image

The deployment to GH-Pages did not work either.
image
image

This may impact @ljmoody if this same issue occurs for the MTL Manual.

@lijenn lijenn changed the title 2024_07: BUG Github Actions - Failed Checks and GH-Pages Deployment Not Working 2024_07: BUG Github Actions - Failed Checks and GH-Pages Deployment Not Working for UpdatingTeam PSD Manual Jul 20, 2024
@lijenn lijenn changed the title 2024_07: BUG Github Actions - Failed Checks and GH-Pages Deployment Not Working for UpdatingTeam PSD Manual 2024_07: BUG Github Actions - Failed Checks and GH-Pages Deployment Not Working for Updating Team PSD Manual Jul 20, 2024
@lijenn lijenn added this to the 2024_07 milestone Jul 20, 2024
@lijenn lijenn added Development Value stream activities in support of technological development. bug These are problems associated with technologies that need to be fixed right away. labels Jul 20, 2024
@lzim
Copy link
Owner

lzim commented Jul 20, 2024

Thanks for looking into this @lijenn
And for tracking the tech dependency between https://mtl.how/manual for Modeling to Learn 3.7 Consult Manual with @retooler work on #authorship_app in Team PSD Manual at https://mtl.how/teampsd_manual

@matomasz
Copy link
Collaborator

Discussed 7/22 Standup with Dev:

@tejaspesquare
Copy link
Collaborator

@lijenn , @matomasz,

To address this problem, it is necessary for us to request @lzim, the owner, to update the permission. We currently do not have access to the settings menu.
For more details (help forum): https://stackoverflow.com/questions/76023778/action-failed-with-the-process-usr-bin-git-failed-with-exit-code-128

@lzim
Copy link
Owner

lzim commented Jul 23, 2024

Thanks @tejaspesquare !

#sim_ui_workflow
@lijenn
@matomasz
@lijenn
@jamesmrollins

With my travel schedule today, I could be available to work with someone on a permissions & tokens related task around 1PM Pacific/3PM Central.

Let me know if we should connect synchronously to resolve this. I will have less availability tomorrow when the strategic planning meeting begins. Thx!

@matomasz
Copy link
Collaborator

@lzim I should be able to hop on a quick call around that time to resolve the settings issue. I will send you a meeting invite shortly.

@lzim
Copy link
Owner

lzim commented Jul 23, 2024

Thanks @matomasz

Will you please send the invite to my Stanford email in case I cannot get on the VA network?

I may also need to connect closer to 3:15-3:30 since my travel was little delayed & my hotel room isn’t ready yet.

Do you have some flexibility to connect a little later?

@matthewtomo
Copy link
Collaborator

@lzim Yes to both questions. See you soon!

@lzim
Copy link
Owner

lzim commented Jul 23, 2024

Thanks @matomasz I got the invite. I’m trying to find a place to take the call & will update shortly.

@matthewtomo matthewtomo assigned matthewtomo and unassigned matomasz Jul 23, 2024
@lzim
Copy link
Owner

lzim commented Jul 23, 2024

wk4 2024_07 #sim_ui_workflow
@matthewtomo
@lzim

Things we reviewed on the call

  • GitHub Settings already were consistent with the Stack Overflow documentation above.

image

@lzim & @matthewtomo reviewed this message:

has no historv in common with QA

  • This part of the message indicates we probably need a Git solution that explains why the pull request of the pages_fix_ch_12_broken_images branch doesn't recognize a shared parent history with QA branch

image

Is this simply due to how gh-pages work overall, as it's only code branch, and not master or QA in the same way as other features branches we create?

@tejaspesquare

@lijenn lijenn moved this from needs_triage to under_development in bug_tracker Jul 24, 2024
@github-project-automation github-project-automation bot moved this to needs_triage in bug_tracker Jul 24, 2024
@matthewtomo
Copy link
Collaborator

Discussed support_workflow
@ljmoody @lijenn @matthewtomo

  • Investigated the issue related to GitHub Pull Request Action Failing
  • Corrected ActionChecker.yml to make a pull request directly into gh-pages branch instead of QA branch.
  • Corrected renderbook.yml to use JamesIves/[email protected] instead of JamesIves/[email protected] (updated version of same action)
  • This resulted in the GitHub Pages for the TeamPSD Manual successfully updating after making a pull request.
  • NOTE: These changes were also made in the lzim/mtl repo, so CI-CD for GitHub pages should also be working for that repo.

@lzim @jamesmrollins @tejaspesquare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug These are problems associated with technologies that need to be fixed right away. Development Value stream activities in support of technological development.
Projects
Status: closed
Development

No branches or pull requests

7 participants