Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024_11 BUG: when logged into TEST instance as a field user, I'm unable to select & use the LOGOFF button #3318

Open
ljmoody opened this issue Nov 19, 2024 · 7 comments
Assignees
Labels
Development Value stream activities in support of technological development. sim ui dev alert from James to Tejas that issues are ready to be worked on by dev sim_ui #sim_ui_workflow includes modeling
Milestone

Comments

@ljmoody
Copy link
Collaborator

ljmoody commented Nov 19, 2024

Discovered 11/19/2024:

All below observed in TEST instance.

Edge browser

  • When logged in as a field user, I could not click the LOGOFF button (or I did and there was no response):
    image
    image

  • When logged in as an Admin, I can select the LOGOFF icon and successfully log off:
    image

Chrome browser

  • When logged in as a field user, I can select the LOGOFF icon and successfully log off:
    image

  • When logged in as an Admin, I can click LOGOFF and get this pop-up, which successfully allows me to log off:
    image

@ljmoody ljmoody added sim_ui #sim_ui_workflow includes modeling Development Value stream activities in support of technological development. labels Nov 19, 2024
@ljmoody ljmoody added this to the 2024_11 milestone Nov 19, 2024
@github-project-automation github-project-automation bot moved this to needs_triage in bug_tracker Nov 19, 2024
@matthewtomo
Copy link
Collaborator

@ljmoody to make sure I understand, the issue this only occurred when:

  • on Edge
  • logged in as non-admin user
  • on moreinfo.hmtl page

@ljmoody
Copy link
Collaborator Author

ljmoody commented Nov 20, 2024

@matthewtomo, apologies if the original comment was confusing - I tried to cover all bases.
Yes, and...
I just poked around and noted this behavior (from the More Info page, logged in as non-Admin, Edge):

  • ✔️ Home button functions correctly
  • Team (chat) will be removed once pushed from DEV>TEST
  • selecting News does nothing
  • ✔️ Report Bug functions correctly
  • selecting Admin Dashboard refreshed the page to the login screen. Non-Admins shouldn't see Admin Dashboard icon in the upper navbar.

@matthewtomo matthewtomo added the sim ui dev alert from James to Tejas that issues are ready to be worked on by dev label Nov 22, 2024
@matthewtomo
Copy link
Collaborator

Discussed Friday Dev Standup wk3 2024_11
@matthewtomo @tejaspesquare

  • on the moreinfo.html page, the LOGOFF button is not opening the "confirm log off" popup as expected, so users are unable to logoff.
  • This appears to be only on the moreinfo.html page and not the admin page for more info.

@matthewtomo matthewtomo moved this from needs_triage to under_development in bug_tracker Nov 22, 2024
@matthewtomo
Copy link
Collaborator

Discussed Dev Standup wk4 2024_11
@matthewtomo @tejaspesquare

  • Dev team has reproduced issue
  • In previous testing @matthewtomo identified the following code from static/js/moduleJS/common.js the is responsible for adding the behavior of the logoff button:
$(".logoff-icon").click(function () {
        endTour();
        //$("#LogoutModel").modal();

        if (pageName.indexOf("ccplay.html") != -1 || pageName.indexOf("mmplay.html") != -1 || pageName.indexOf("aggplay.html") != -1 || pageName.indexOf("psyplay.html") != -1 || pageName.indexOf("spplay.html") != -1) {
            $("#confirmSaveGamePopup").modal();
        } else {
            $("#LogoutModel").modal();
        }

    });
  • If pasted in the console and ran, then the logoff button functions as expected
  • @matthewtomo is unsure if there is an error encountered in the file that prevents the code from being run in the first place

@tejaspesquare
Copy link
Collaborator

Hi @ljmoody , @matthewtomo,

We have addressed these points & code has been moved to DEV environment. Can you please verify at your end & let us know in case any concern.

More Info page - Logoff confirmation popup Non-Admin user
image

More Info page - Hide Admin Dashboard in case Non-Admin user
image

@ljmoody
Copy link
Collaborator Author

ljmoody commented Nov 28, 2024

@tejaspesquare and @matthewtomo,

  • Tested today in DEV instance, on VA laptop, Chrome browser, logged into _ind world.
  • From More Info page, when Logoff button is clicked, behavior observed is correct. Thanks, Tejas 🚀 !
  • and the Admin Dashboard button is no longer showing 💪
    image

@matthewtomo matthewtomo modified the milestones: 2024_11, 2024_12 Dec 5, 2024
@matthewtomo
Copy link
Collaborator

Discussed Dev Standup wk2 2024_01
@matthewtomo @tejaspesquare

  • This fix is currently only available in DEV environment.
  • @matthewtomo will prioritize Validating changes in the TEST environment to keep updates rolling through the pipeline

@matthewtomo matthewtomo moved this from under_development to testing in bug_tracker Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development Value stream activities in support of technological development. sim ui dev alert from James to Tejas that issues are ready to be worked on by dev sim_ui #sim_ui_workflow includes modeling
Projects
Status: testing
Development

No branches or pull requests

3 participants