Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024_12: BUG unable to revise team member's permissions & permissions (Member) do not stay as selected in PROD instance of Sim UI #3326

Open
ljmoody opened this issue Dec 5, 2024 · 17 comments
Assignees
Labels
bug These are problems associated with technologies that need to be fixed right away. Development Value stream activities in support of technological development. sim ui dev alert from James to Tejas that issues are ready to be worked on by dev sim_ui #sim_ui_workflow includes modeling
Milestone

Comments

@ljmoody
Copy link
Collaborator

ljmoody commented Dec 5, 2024

Observed while testing for #3237 today. This may be 2 bugs in 1 card.
PROD instance, VA laptop, Edge browser. Logged into Sim UI as Administrator.

Issue 1:

  • I added myself (praxis account) to the team - apparently I accidentally chose "Team Lead" instead of "Member." (or so I thought)

  • After noticing the mistake, I re-entered the Edit Setup pop-up, selected to edit my praxis permissions, selected member and--it never happened:
    image

  • Here's a snapshot of the inspect console:
    image

  • Performed a hard refresh with console open. That exited me out of all pop-ups and back to the Admin Dashboard.

  • Tried again, same results.

Issue 2:

  • Since refreshing and trying to change my permissions didn't work, I decided to delete myself (praxis) from the team, then re-add myself.

  • Selected the team, then chose Edit:
    image

  • Added myself to the team and entered this exactly as shown: note the selection of Member
    image

  • Add pop-up populated correctly:
    image

  • And yet, when I click Done and the team roster refreshes--it shows me as Team Lead:
    image

@ljmoody ljmoody added sim_ui #sim_ui_workflow includes modeling bug These are problems associated with technologies that need to be fixed right away. Development Value stream activities in support of technological development. labels Dec 5, 2024
@ljmoody ljmoody added this to the 2024_12 milestone Dec 5, 2024
@github-project-automation github-project-automation bot moved this to needs_triage in bug_tracker Dec 5, 2024
@matthewtomo
Copy link
Collaborator

matthewtomo commented Dec 6, 2024

Discussed Friday Dev Standup wk1 2024_12
@matthewtomo @tejaspesquare

  • @matthewtomo will further investigate this issue and report back here with more information

@tejaspesquare
Copy link
Collaborator

Hello @ljmoody, @matthewtomo ,

If I followed above steps correctly then this is working fine for me.

1.Adding user with a role of a member
image
2. Member shown with a correct Role
image
3.Edit user role permission to Admin from a Member.
image
4.Working as expected.
image

@ljmoody
Copy link
Collaborator Author

ljmoody commented Dec 17, 2024

Thanks for showing what you observed, @tejaspesquare. I tested again today after a hard refresh this morning - with similar results, but some additional information, perhaps? Please see below.
fyi: @matthewtomo


  1. Logged into Sim UI PROD. On VA laptop, edge browser, as admin. From Admin Dashboard, created a new team:
    image

  2. From Setup - Add Members pop-up, successfully added a team member as a Member. Then clicked Done.
    image

  3. When I select the team and click the Edit icon, the Edit Setup pop-up now shows Team Lead permissions for this added member in both _ind and _team worlds:
    image

ℹ️: BOTH add and edit Select Permissions dropdowns do not have "Member" as an option - using your team as reference:
image
image

@tejaspesquare
Copy link
Collaborator

Hello @ljmoody,

: BOTH add and edit Select Permissions dropdowns do not have "Member" as an option - using your team as reference:

I'm able to see "Member" as an option under Select Permissions drop-down.

Setup - Add Members
image

Setup - Edit Members
image

@matthewtomo
Copy link
Collaborator

Discussed Dev Standup wk2 2024_01
@matthewtomo @tejaspesquare

  • @ljmoody if you are still experiencing this issue, @matthewtomo can hop on a call to further troubleshoot with you
  • I think there has been weird behavior before when editing an account's role while signed into that account. Only admins should be able to edit roles in the admin dashboard. This issue might be further resolved by other changes in the pipeline.

@ljmoody
Copy link
Collaborator Author

ljmoody commented Jan 8, 2025

@matthewtomo, thanks for your response. I'd like to have a call with you to discuss & troubleshoot. Do you have availability this Wed/Th?

FYI:

  • I went back into Tejas' team and now DO see "Member" in the dropdown as an option now.
  • I checked again this afternoon and had a similar result with defined "Member" changing to "Team Lead" once clicking Done button from the Setup - Add Members pop-up:
    image

@matthewtomo
Copy link
Collaborator

@matthewtomo, thanks for your response. I'd like to have a call with you to discuss & troubleshoot. Do you have availability this Wed/Th?

@ljmoody, yes, I can meet later today. I will message you on teams.

@matthewtomo
Copy link
Collaborator

matthewtomo commented Jan 8, 2025

@tejaspesquare

  • The current issue being faced on this card is as follows
  • When creating a team, user accounts can be added as either a "Administrator", "Team Lead", or "Member".
  • When adding the users, they will initially be added as the role they were assigned, but after clicking done, the page will refresh and the account with a "Member" role will now have a "Team Lead" role.
    image
    image
  • This behavior is also showing on DEV instance, so we know it is not currently addressed:
    image
    image

@tejaspesquare
Copy link
Collaborator

Hello @ljmoody , @matthewtomo ,

User permission related issue has been resolved & can be verified on DEV instance.

Before Submission

image

View Team details

image

@matthewtomo
Copy link
Collaborator

Discussed Friday Dev Standup wk2 2024_01
@matthewtomo @tejaspesquare

  • @matthewtomo and @tejaspesquare confirm that the role is no longer being switched in DEV for team worlds.
  • Role is still being switched in shared and ind worlds, which should not be an issue if those worlds are only for admin users to use.
    • @ljmoody, does this match your understanding of who uses the shared and ind worlds?
    • If this assumption is incorrect, @tejaspesquare has notified me that further development will be required for changing behavior in those two world types (shared and ind).

@matthewtomo
Copy link
Collaborator

@ljmoody, I would love to talk about this card when we discuss #3331

@matthewtomo matthewtomo added the sim ui dev alert from James to Tejas that issues are ready to be worked on by dev label Jan 28, 2025
@matthewtomo
Copy link
Collaborator

Discussed ad_hoc wk04 2024_01
@matthewtomo @ljmoody

  • @tejaspesquare would you be able to hop on a quick call tomorrow about this card?
  • I would like to talk about implementing the fix into ind and shared worlds and a time estimate for how long that tasking would take.

@tejaspesquare
Copy link
Collaborator

Hello @matthewtomo ,

  • @tejaspesquare would you be able to hop on a quick call tomorrow about this card?

Certainly. We can go over your concerns & related efforts.

@matthewtomo
Copy link
Collaborator

Discussed Wednesday Dev Standup wk?? 2024_??
@matthewtomo @tejaspesquare

  • Change potentially not possible for shared worlds due to how shared worlds are set up
  • @tejaspesquare will provide estimate tomorrow on how long to implement change for ind worlds.
  • @tejaspesquare will check to see what estimate might be to implement for shared world (if possible)

@tejaspesquare
Copy link
Collaborator

Hello @matthewtomo ,

  • @tejaspesquare will provide estimate tomorrow on how long to implement change for ind worlds.

To implement change for this requirement will be required approx. 4-5 hrs. including investigation, development & testing.

  • @tejaspesquare will check to see what estimate might be to implement for shared world (if possible)

Developer requested some time for investigation before calculating this estimation. This is expected to be available by 4-Feb Monday EOD.

@matthewtomo
Copy link
Collaborator

Discussed Dev Standup wk4 2024_01
@matthewtomo @tejaspesquare

  • @matthewtomo will investigate current behavior in DEV environment and compare it to desired behavior

@matthewtomo
Copy link
Collaborator

Hello @matthewtomo ,

  • @tejaspesquare will provide estimate tomorrow on how long to implement change for ind worlds.

To implement change for this requirement will be required approx. 4-5 hrs. including investigation, development & testing.

  • @tejaspesquare will check to see what estimate might be to implement for shared world (if possible)

Developer requested some time for investigation before calculating this estimation. This is expected to be available by 4-Feb Monday EOD.

For shared world 2-3 hours expected. (Matthew will confirm intended behavior before moving forward on this development)

  • Would make all three roles present for all three worlds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug These are problems associated with technologies that need to be fixed right away. Development Value stream activities in support of technological development. sim ui dev alert from James to Tejas that issues are ready to be worked on by dev sim_ui #sim_ui_workflow includes modeling
Projects
Status: needs_triage
Development

No branches or pull requests

3 participants