Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with calculateTF #1

Open
ma-laforge opened this issue May 8, 2021 · 2 comments
Open

Bug with calculateTF #1

ma-laforge opened this issue May 8, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@ma-laforge
Copy link
Owner

I couldn't quite figure out what gets returned by minreal() in the original calculateTF.m file or how it gets split into STF and NTF.

In addition to this, ControlSystems.jl's implementation of ss->tf->minreal() generates an error:
-->see: JuliaControl/ControlSystems.jl#479
@ma-laforge ma-laforge changed the title Bug with calculateTF Bug with calculateTF May 8, 2021
@ma-laforge ma-laforge added the bug Something isn't working label May 8, 2021
@baggepinnen
Copy link

minreal in ControlSystems should now be considerably more robust, it now uses MatrixPencils.jl for the computations. Hopefully it resolves your issue!

@ma-laforge
Copy link
Owner Author

Excellent. Thanks for letting me know @baggepinnen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baggepinnen @ma-laforge