You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a variant that takes ownership over a Box (or T?) and calls its destructor (EDIT: This requires a raw Block pointer, which we can probably get via a Deref on GlobalBlock).
Make regenerated Metal code import/use the correct dispatch_data_t type (preferably taking &DispatchObject and calling .as_raw()?).
Ensure calling set_finalizer() is still a valid thing to do?
Can the header translator parse #define or are we expected to redefine them ourselves?
Add a variant that takes ownership over a Box (or T?) and calls its destructor (EDIT: This requires a raw Block pointer, which we can probably get via a Deref on GlobalBlock).
Yeah, could be useful. A variant which takes &'static [u8] could also be, and so could taking Arc<[u8]>.
Maybe it could even be generic over T: AsRef<[u8]> + 'static? Though a difficulty here is in thread-safety, I'm not sure, but I think + Send would also be required (maybe depending on the queue the destructor is run on)?
Hmm... It actually seems like the block passed to dispatch_data_create doesn't take any parameters, so it would have to keep a pointer to the original data inside the block? That seems odd? Maybe I don't understand this API enough?
Make regenerated Metal code import/use the correct dispatch_data_t type (preferably taking &DispatchObject and calling .as_raw()?).
See #681; I intend to start work on that soon, that should resolve this kind of issue.
Can the header translator parse #define or are we expected to redefine them ourselves?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
madsmtm
added
enhancement
Fixes #699
TODO
Box(orT?) and calls its destructor (EDIT: This requires a rawBlockpointer, which we can probably get via aDerefonGlobalBlock).dispatch_data_ttype (preferably taking&DispatchObjectand calling.as_raw()?).set_finalizer()is still a valid thing to do?#defineor are we expected to redefine them ourselves?