Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

product view validation.js undefined this.radioCheckboxClosest #37713

Open
sheepfy opened this issue Jul 4, 2023 · 12 comments · May be fixed by #39451
Open

product view validation.js undefined this.radioCheckboxClosest #37713

sheepfy opened this issue Jul 4, 2023 · 12 comments · May be fixed by #39451
Assignees
@magentoabu
Labels
Area: Framework Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@sheepfy
Copy link
Contributor

sheepfy commented Jul 4, 2023

https://github.com/magento/magento2/blame/2abc466714ec397efbe865ac1f10b7141aa586f3/app/code/Magento/Catalog/view/frontend/web/product/view/validation.js#L45

This line will be always undefined since the jquery.validate.js got updated to the latest version.

jquery.validate.js is now doing:
this.settings.errorPlacement.call( this, place, $( element ) );
instead of:
this.settings.errorPlacement( place, $( element ) );

Therefor in product/view/validation.js "this" variable is changed and this.radioCheckboxClosest is not defined.
It needs to be updated to "this.settings.radioCheckboxClosest"
@m2-assistant
Copy link

m2-assistant bot commented Jul 4, 2023

Hi @sheepfy. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@sheepfy
Copy link
Contributor Author

sheepfy commented Jul 4, 2023

cc @magento-engcom-team

@engcom-Bravo engcom-Bravo added Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it labels Jul 4, 2023
@sheepfy
Copy link
Contributor Author

sheepfy commented Jul 4, 2023

Also after fixing this issue, when clicking "add to cart" button first time, highlight errors will appear, which is good. But if you click second time the "add to cart" button, the error option will get removed.

@sheepfy
Copy link
Contributor Author

sheepfy commented Jul 4, 2023

Added test in vanila magento, configurable product with extra custom options of type checkbox (replicable also for radios)

image

@sheepfy
Copy link
Contributor Author

sheepfy commented Jul 4, 2023

If using the correct selector in there:

First click:
image
Second click:
image

@sheepfy sheepfy mentioned this issue Jul 4, 2023
Closed
@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Jul 5, 2023
@engcom-Hotel engcom-Hotel self-assigned this Jul 10, 2023
@m2-assistant
Copy link

m2-assistant bot commented Jul 10, 2023

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

Hello @sheepfy,

Thanks for the report and collaboration!

We have tried to reproduce the issue in the 2.4-develop branch and it seems the issue is reproducible as mentioned in the description.

Please have a look at the below screenshot for reference:

image

Hence confirming the issue.

Thanks

@engcom-Hotel engcom-Hotel added Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Framework and removed Issue: ready for confirmation labels Jul 10, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9121 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Jul 10, 2023

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel moved this to Ready for Development in Low Priority Backlog Aug 19, 2024
@magentoabu
Copy link

@magento I'm working on this

@sheepfy
Copy link
Contributor Author

sheepfy commented Dec 8, 2024

@magentoabu The fix was already made here:
https://github.com/magento/magento2/pull/37714/files

@magentoabu
Copy link

@sheepfy But not in this instance.

@magentoabu magentoabu linked a pull request Dec 9, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magentoabu magentoabu

Labels
Area: Framework Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Low Priority Backlog
Status: Ready for Development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

undefined validation radiocheckboxclosest issue fixed magentoabu/magento2
Fixes issue 37713
5 participants
@magentoabu @sheepfy @engcom-Bravo @engcom-Hotel @github-jira-sync-bot