Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog link widgets uses incorrect URL #39464

Open
2 of 5 tasks
rikwillems opened this issue Dec 11, 2024 · 6 comments
Open
2 of 5 tasks

Catalog link widgets uses incorrect URL #39464

rikwillems opened this issue Dec 11, 2024 · 6 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7-p3 Indicates original Magento version for the Issue report.

Comments

@rikwillems
Copy link
Contributor

Preconditions and environment

Version tested 2.4.7-p3

Steps to reproduce

  1. Multistore setup
  2. Add categories and products
  3. Change the url key of a product and category for a store view
  4. Add a catalog category link and category product link widget to a page, linked to the category/product in step (3)

Expected result

Links in the widget go to the correct url of the selected product/category.

Actual result

Links go to the URL that was first inserted into url_rewrite, which now has redirect_type 301.

Additional information

The filter to retrieve the url rewrite misses the redirect type parameter. Adding that to the filter leads to the expected result.
\Magento\Catalog\Block\Widget\Link line 80.

Althought the links work, through a redirect you get to the correct page, the link in html source is invalid. This can have an SEO impact for the merchant.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Dec 11, 2024

Hi @rikwillems. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@rikwillems
Copy link
Contributor Author

You can use the following patch to work around the issue.

--- a/vendor/magento/module-catalog/Block/Widget/Link.php
+++ b/vendor/magento/module-catalog/Block/Widget/Link.php
@@ -81,6 +81,7 @@
                 UrlRewrite::ENTITY_ID => $rewriteData[1],
                 UrlRewrite::ENTITY_TYPE => $rewriteData[0],
                 UrlRewrite::STORE_ID => $store->getId(),
+                UrlRewrite::REDIRECT_TYPE => 0,
             ];
             if (!empty($rewriteData[2]) && $rewriteData[0] == ProductUrlRewriteGenerator::ENTITY_TYPE) {
                 $filterData[UrlRewrite::METADATA]['category_id'] = $rewriteData[2];

@engcom-Bravo engcom-Bravo self-assigned this Dec 11, 2024
Copy link

m2-assistant bot commented Dec 11, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7-p3 Indicates original Magento version for the Issue report. label Dec 11, 2024
@engcom-Bravo
Copy link
Contributor

Hi @rikwillems,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

Screenshot 2024-12-27 at 10 30 12 am Screenshot 2024-12-27 at 10 30 20 am

Links in the widget going to the correct url of the selected product/category.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce the issue if the issue is still reproducible.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Dec 27, 2024
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Dec 27, 2024
@rikwillems
Copy link
Contributor Author

@engcom-Bravo Could you be so kind and recheck the issue? The results are right, as your screenshot shows. But, you get to that URL because of a 301 redirect that is generated. The actual link on the page that is created by the widget is the original, not the correct new URL.

@engcom-Bravo
Copy link
Contributor

Hi @rikwillems,

Thanks for your update.

We have tried to reproduce the issue in Latest 2.4-develop instance and results were the same.Could you please provide screencast or screenshots if possible to proceed further.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.7-p3 Indicates original Magento version for the Issue report.
Projects
Development

No branches or pull requests

2 participants