Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL switch problem in a store with a redirection that exists in another store #39470

Open
1 of 5 tasks
Yoann-D opened this issue Dec 12, 2024 · 10 comments
Open
1 of 5 tasks
Labels
Area: Framework Component: CmsUrlRewrite Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.7-p3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@Yoann-D
Copy link

Yoann-D commented Dec 12, 2024

Preconditions and environment

  • Magento version 2.4.7-p3
  • Do not use the $oldStore to fetch existing urlwrites

Steps to reproduce

  • Have multiple Websites and multiples stores
  • Create a custom redirection for a website A on a URL common to different websites (blog to blogs for example)
  • Go to Website B, and on the blog page, make a store switch

Expected result

The Rewrite url created for another website A must not have any link with Website B

Actual result

For code in file : vendor/magento/module-url-rewrite/Model/StoreSwitcher/RewriteUrl.php ligne 80
image

Currently my store IDs on my website B are 7 and 25.

The code returns me a redirect to website A

image

So we have $existingRewrite is yes and $currentRewrite is false . So we are sent back to the BaseUrl

image

The problem in the $existing write variable, we will not filter with the $oldStoreId

To correct this I added the $oldStoreId in the filter

image

Additional information

This my fix
switcher.zip

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Dec 12, 2024

Hi @Yoann-D. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Dec 12, 2024
@engcom-Bravo engcom-Bravo added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Reported on 2.4.7-p3 Indicates original Magento version for the Issue report. labels Dec 12, 2024
@Yoann-D Yoann-D closed this as completed Dec 12, 2024
@Yoann-D Yoann-D reopened this Dec 12, 2024
@engcom-Hotel engcom-Hotel self-assigned this Dec 12, 2024
Copy link

m2-assistant bot commented Dec 12, 2024

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

Hello @Yoann-D,

Thanks for the report and collaboration!

We request you to please elaborate more on the below steps (If possible share screencast to demonstrate):

  • Create a custom redirection for a website A on a URL common to different websites (blog to blogs for example)
  • Go to Website B, and on the blog page, make a store switch

Thanks

@engcom-Hotel engcom-Hotel moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Dec 12, 2024
@engcom-Hotel engcom-Hotel added Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation labels Dec 12, 2024
@Yoann-D
Copy link
Author

Yoann-D commented Dec 12, 2024

Hello @engcom-Hotel ,

This redirection for Website A

image

On my Website B I don't want a redirect, so the url must be "/blog"
Store B FR => StoreId=25
Store B DE => StoreId=7
I go to the URL of my store B www.storeb.com/fr/blog

I switch to the DE for example via the store switcher www.storeb.com/de/blog
This redirects me to www.storeb.com/de/ Because it finds a redirection in database for another store
image

So the check is done, and $targetUrl becomes the BaseUrl
image

@engcom-Hotel
Copy link
Contributor

Hey @Yoann-D,

Thanks for the reply!

But its unclear to perform the below step, please elaborate more on this or share a screencast for reference:

  • Create a custom redirection for a website A on a URL common to different websites (blog to blogs for example)

Thanks

@Yoann-D
Copy link
Author

Yoann-D commented Dec 13, 2024

Hey @engcom-Hotel

image

On other Websites, there is no redirection, we must access www.websiteB.fr/fr/blog

@engcom-Hotel
Copy link
Contributor

Thanks @Yoann-D for the information!

We are trying to reproduce the issue. We will get back to you soon.

Thanks

@engcom-Hotel
Copy link
Contributor

Hello @Yoann-D,

Thanks for the report and collaboration!

We are able to reproduce the issue in the latest development branch i.e. 2.4-develop. Hence confirming the issue for further processing.

Thanks

@engcom-Hotel engcom-Hotel added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: CmsUrlRewrite Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P3 May be fixed according to the position in the backlog. and removed Issue: needs update Additional information is require, waiting for response labels Dec 17, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13530 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Dec 17, 2024

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: CmsUrlRewrite Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.7-p3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

No branches or pull requests

4 participants