Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento hierarchy url does not update when identifier of CMS page changes #39482

Open
1 of 5 tasks
reense opened this issue Dec 16, 2024 · 2 comments
Open
1 of 5 tasks
Assignees
Labels
Issue: ready for confirmation Reported on 2.4.7-p3 Indicates original Magento version for the Issue report.

Comments

@reense
Copy link
Contributor

reense commented Dec 16, 2024

Preconditions and environment

  • Adobe Commerce ver. 2.4.7-p3
  • CMS hierarchy enabled

Steps to reproduce

  1. Create a CMS Page with identifier 'test'
  2. Update the identifier to 'test2'
  3. Look in the magento_versionscms_hierarchy_node to see if the request_url of your CMS page has been updated

Expected result

The magento_versionscms_hierarchy_node row has been updated with the correct request_url

Actual result

The update does not happen.

Additional information

Issue Summary:
In the cms_page_save_after observer, the VersionsCms module checks whether the page identifier has been changed. If it has, the module attempts to find and update corresponding entries in the magento_versionscms_hierarchy_node table. This update logic is handled in the method Magento\VersionsCms\Model\ResourceModel\Hierarchy\Node::updateRequestUrlsForTreeByXpath.

Problem Details:
The issue lies in the following query within the method:

->where(
    'xpath LIKE ? OR xpath = ?',
    $xpath . '%/'
)

Here, Magento is looking for xpath values that either end with a slash or match the exact value appended with a slash. However, the xpath column in the magento_versionscms_hierarchy_node table does not store values that end with a slash. As a result, this query always returns zero results, and the expected row update never occurs. Removing the slash in the query above results in Magento correctly updating the rows.

Links
This problem has already been discussed in this issue, however no solution was provided in that ticket.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Dec 16, 2024

Hi @reense. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Dec 17, 2024

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: ready for confirmation Reported on 2.4.7-p3 Indicates original Magento version for the Issue report.
Projects
Status: Ready for Confirmation
Development

No branches or pull requests

3 participants