Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I am confused about the current state of the Magento license. #39493

Open
1 of 5 tasks
damienwebdev opened this issue Dec 18, 2024 · 6 comments
Open
1 of 5 tasks
Labels
Issue: ready for confirmation Progress: PR Created Indicates that Pull Request has been created to fix issue Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@damienwebdev
Copy link
Member

damienwebdev commented Dec 18, 2024

Summary

I am confused by the current state of the Magento license.

On the one-hand, we have the License.txt in the root of the project indicating:

Grant of Copyright License. Licensor grants You a worldwide, royalty-free, non-exclusive, sublicensable license, for the duration of the copyright, to do the following:

         1. to reproduce the Original Work in copies, either alone or as part of a collective work;

         2. to translate, adapt, alter, transform, modify, or arrange the Original Work, thereby creating derivative works ("Derivative Works") based upon the Original Work;

         3. to distribute or communicate copies of the Original Work and Derivative Works to the public, with the proviso that copies of Original Work or Derivative Works that You distribute or communicate shall be licensed under this Open Software License;

         4. to perform the Original Work publicly; and

         5. to display the Original Work publicly. 

On the other hand, there are now files in the codebase that read:

/************************************************************************
 * Copyright 2024 Adobe
 * All Rights Reserved.
 *
 * NOTICE: All information contained herein is, and remains
 * the property of Adobe and its suppliers, if any. The intellectual
 * and technical concepts contained herein are proprietary to Adobe
 * and its suppliers and are protected by all applicable intellectual
 * property laws, including trade secret and copyright laws.
 * Dissemination of this information or reproduction of this material
 * is strictly forbidden unless prior written permission is obtained
 * from Adobe.
 * ***********************************************************************

Specifically:

Grant of Copyright License. Licensor grants You a worldwide, royalty-free, non-exclusive, sublicensable license, for the duration of the copyright, to ... distribute or communicate copies of the Original Work and Derivative Works to the public, with the proviso that copies of Original Work or Derivative Works that You distribute or communicate shall be licensed under this Open Software License;

Dissemination of this information or reproduction of this material is strictly forbidden unless prior written permission is obtained from Adobe.

These two statements are contradictory. Please clarify the current state of the license as applicable to the open source codebase.

Examples

  1. License.txt
  2. New Copyright Notice

Proposed solution

Please let me know which is behavior is correct, as they cannot simultaneously be correct given that they are logically opposed.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@damienwebdev damienwebdev added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Dec 18, 2024
Copy link

m2-assistant bot commented Dec 18, 2024

Hi @damienwebdev. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@rhoerr
Copy link

rhoerr commented Dec 18, 2024

Related:
#37631 (comment)
#39099 (comment)

@ihor-sviziev
Copy link
Contributor

@sidolov, could you please reply? Will all these Adobe notices be removed from the Magento Open Source version?

@chernenm
Copy link

hi @ihor-sviziev, @damienwebdev, this notice was used by our Adobe internal team member by mistake, we will remove it asap.

@hostep
Copy link
Contributor

hostep commented Dec 18, 2024

@chernenm: it would help a lot if the new copyright format is being fully validated by your coding standards tool, right now it only checks for the first line and doesn't care what other lines follow. If this can be checked fully, this problem wouldn't have happened probably.
Also having some documentation being published about it for the non-Adobe contributors here on github would help significantly for people who don't know yet about this new format.

@engcom-Bravo
Copy link
Contributor

Hi @damienwebdev,

Thanks for your reporting and collaboration.

Adobe Commerce Engineering team started working on this issue. We will reach out to you if we need more information and you will get notified once the issue is fixed. Please leave comments for any further questions.

Hence moving this issue to ON HOLD.

Thank you!

@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to On Hold in Issue Confirmation and Triage Board Dec 19, 2024
@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Dec 20, 2024
@github-jira-sync-bot github-jira-sync-bot added Progress: dev in progress Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: dev in progress labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: ready for confirmation Progress: PR Created Indicates that Pull Request has been created to fix issue Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Development

No branches or pull requests

7 participants