Unable to read anything from the completions

[nolovelost]

As the tile says, due to the way the face attributes are set (or maybe some overlay?), I'm unable to read anything returned as candidates for completion. acm-frame-select-face itself is working fine but I haven't been able to change the unselected candidates' face attributes to make them readable. I've tried change foreground attributes for several acm- and lsp-bridge- faces but none of the changes have affected it. acm-frame-select-face does properly change the selected one from the list however.

Could you let me know exactly what face should I be modifying and maybe hint at what else could be causing this?

Below is an example image:

In this screenshot you can see the completion frame is dark upon dark making it very difficult to read. On actual use in fact, inside emacs, the text is way darker and impossible to read.

[manateelazycat]

How did you reproduce it?

[nolovelost]

I haven't changed anything related to face attributes specific to lsp-bridge or acm. In fact, everything related to lsp-bridge are left as is and I let it's plug-and-play nature to work as intended. Below is the whole snippet of the code that I entered to make everything work,

Also, this is my simple window setup I do in the beginning to change my background and related things in case it's helpful,

[manateelazycat]

Have you try emacs -Q and only load lsp-bridge config for compare test?

[nolovelost]

So I'm finally able to reproduce it reliably. The line (set-background-color "#161616") does set the background for the frame to the dark color. However, (set-foreground-color "burlywood3") does not set the text to the bright colour. It does set everywhere else in my emacs instance but the completion frame is only taking the background colour for some reason.

[nolovelost]

To illustrate my above comment. Following is my Emacs startup buffer without and then with (set-foreground-color "burlywood3"):

Then following is the completion frame without and then with (set-foreground-color "burlywood3"), meaning basically the same:

Maybe there is a set-face-attribute that can fix these?

[nolovelost]

Also, for list of faces if that is useful.

acm-

lsp-bridge-

[nolovelost]

I have "fixed" this for now. It is very hacky but my solution was to override the acm-frame-init-colors function in my init file. Following I've provided how I'm forcing it to set it to arbitrary values for now, which is not exactly ideal but I want it up and running for now.

(defun acm-frame-init-colors (&optional force)
  (set-face-attribute 'acm-frame-default-face nil :background "white" :foreground "black")
  (set-face-attribute 'acm-frame-select-face nil  :background "burlywood3" :foreground "black"))

It doesn't seem right to me that in acm-frame-init-colors, any change to set-foreground\background-face for acm-frame-default-face isn't being respected. Strangely enough it is respecting changes to acm-frame-select-face.

Also I've noticed in acm-frame-init-colors that :foreground for acm-frame-default-face is missing. However, it still doesn't answer why setting using set-face-attribute for default face isn't working but for select face it is.

    ;; Make sure menu follow the theme of Emacs.
    (when (or force (equal (face-attribute 'acm-frame-default-face :background) 'unspecified))
      (set-face-background 'acm-frame-default-face (acm-frame-color-blend default-background blend-background (if is-dark-mode 0.8 0.9))))
    (when (or force (equal (face-attribute 'acm-frame-select-face :background) 'unspecified))
      (set-face-background 'acm-frame-select-face (acm-frame-color-blend default-background blend-background 0.6)))
    (when (or force (equal (face-attribute 'acm-frame-select-face :foreground) 'unspecified))
      (set-face-foreground 'acm-frame-select-face (face-attribute 'font-lock-function-name-face :foreground)))))

EDIT: Things aren't really "fixed" after all. It seems I can change the background that way but foreground is still stuck on black. It's still better than nothing though.

[manateelazycat]

@nolovelost Did you use lsp-bridge in terminal or GUI?

[nolovelost]

This is in GUI. Native windows build v29.1.

[manateelazycat]

Maybe cause by

lsp-bridge/acm/acm.el

Line 755 in 6f08095

(advice-add #'load-theme :after #'acm-reset-colors))

[eotsn]

I'm not sure if it's the same issue, but I also experienced trouble with persisting color changes when I was attempting to support switching themes using customize-themes. The problem I found was that the acm-reset-colors calls acm-frame-init-colors with the optional force value, overriding any customizations depending on when you load your theme.

It's probably not the best solution, but I found the following workaround:

;; Prevent `acm-reset-colors' from overriding theme customizations.
(advice-add 'acm-frame-init-colors :around (lambda (orig-func &rest _) (funcall orig-func)))