Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salting machine-id hash #26

Open
polshpik opened this issue Dec 1, 2024 · 1 comment
Open

Salting machine-id hash #26

polshpik opened this issue Dec 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@polshpik
Copy link

polshpik commented Dec 1, 2024

In case of database leak it is possible to cross-reference machine-id hashes from other leaks, which is rather serious privacy issue taking into account collected data.
I suggest changing line 82 from
hashed_id = hashlib.sha256(machine_id.encode()).digest()
to
hashed_id = hashlib.sha256(machine_id.encode() + b"manjarodatadonor").digest()
It will change ids for machines already accounted during testing, so change should be coordinated with server-side.

@romangg
Copy link
Member

romangg commented Dec 1, 2024

In case of database leak it is possible to cross-reference machine-id hashes from other leaks, which is rather serious privacy issue taking into account collected data.

What other leaks are you thinking about? Your random social media platform doesn't have access to your machine id.

hashed_id = hashlib.sha256(machine_id.encode() + b"manjarodatadonor").digest()

We can still do that.

@romangg romangg added the enhancement New feature or request label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants