JSON schema validation is broken

[cthoyt]

I found that JSON schema validation does not do what's expected while working on #431. The following code

sssom-py/tests/test_validate.py

Lines 32 to 39 in 69237d5

	def test_validate_json_fail(self):
	"""
	Test if JSONSchemaValidation fail is as expected.
	In this particular test case, the 'mapping_justification' slot
	does not have EntityReference objects, but strings.
	"""
	self.assertRaises(ValidationError, validate, self.bad_msdf1, self.validation_types)

Claims to be testing 'mapping_justification' slot does not have EntityReference objects, but strings., but that is not the error that is thrown. There the main issues here are:

• The test is very very opaque as to what it's testing
• A validation error is raised, but not the expected one, and this goes undetected

[matentzn]

I did not encounter this anymore after extensive work on validation (after latest refactor). Closing but please reopen if still an issue.