Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prop scrollTop is not working? onScroll event cause a bug. Gif proof #28

Open
JumpAttacker opened this issue Sep 8, 2020 · 4 comments

Comments

@JumpAttacker
Copy link

JumpAttacker commented Sep 8, 2020

Hey, seems code do noting with props.scrollTop

also
if onScroll event is not undefined (and i change state in this handle), its put in dom all elements above

https://gfycat.com/BrokenInsignificantChinchilla

upd
seems its UNSAFE_componentWillReceiveProps doing that

@JumpAttacker JumpAttacker changed the title prop scrollTop is not working? prop scrollTop is not working? onScroll event cause a bug. Gif proof Sep 8, 2020
@marchaos
Copy link
Owner

marchaos commented Dec 1, 2020

I believe this is fixed in 3.0.0 - I can probably back port the fix to 2.x

@laurelgr
Copy link

@marchaos you mentioned 3.0.0, are you planning on releasing it ? I noticed current version is still 2.x

@laurelgr
Copy link

After looking a bit, in fact latest npm version is 3.0.0-beta13, which seems to be typescript branch (and pending PR) if I am not mistaken. A bit confusing, especially with the example still being from 2.x and not compatible anymore

@laurelgr
Copy link

Maybe either update the README to use the 2.1.30 version from npm, or put latest tag to 2.1.30 version instead, and beta tag to 3.0.0-beta13 ? Changing the tags would avoid people downloading a version with wrong README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants