From e36766b77dddfbe5bc0c52adca515f06afb653a1 Mon Sep 17 00:00:00 2001 From: Daxter Date: Mon, 14 May 2012 13:40:05 -0500 Subject: [PATCH 1/2] Allow custom title for Index pages --- lib/active_admin/views/pages/index.rb | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/active_admin/views/pages/index.rb b/lib/active_admin/views/pages/index.rb index 121c34d88fb..3b1df314273 100644 --- a/lib/active_admin/views/pages/index.rb +++ b/lib/active_admin/views/pages/index.rb @@ -5,7 +5,14 @@ module Pages class Index < Base def title - active_admin_config.plural_resource_label + case config[:title] + when Symbol, Proc + call_method_or_proc_on(resource, config[:title]) + when String + config[:title] + else + active_admin_config.plural_resource_label + end end def config From baba30bac5dd61d42cd813a7a6f961a73188c6df Mon Sep 17 00:00:00 2001 From: Daxter Date: Tue, 15 May 2012 16:23:50 -0500 Subject: [PATCH 2/2] added cukes and slimmed down index title functionality --- features/index/page_title.feature | 12 ++++++++++++ lib/active_admin/views/pages/index.rb | 5 +---- 2 files changed, 13 insertions(+), 4 deletions(-) create mode 100644 features/index/page_title.feature diff --git a/features/index/page_title.feature b/features/index/page_title.feature new file mode 100644 index 00000000000..7952fdb4e3d --- /dev/null +++ b/features/index/page_title.feature @@ -0,0 +1,12 @@ +Feature: Index - Page Title + + Modifying the page title on the index screen + + Scenario: Set a string as the title + Given an index configuration of: + """ + ActiveAdmin.register Post do + index :title => "Awesome Title" + end + """ + Then I should see the page title "Awesome Title" diff --git a/lib/active_admin/views/pages/index.rb b/lib/active_admin/views/pages/index.rb index 3b1df314273..627d83c5a7f 100644 --- a/lib/active_admin/views/pages/index.rb +++ b/lib/active_admin/views/pages/index.rb @@ -5,10 +5,7 @@ module Pages class Index < Base def title - case config[:title] - when Symbol, Proc - call_method_or_proc_on(resource, config[:title]) - when String + if config[:title].is_a? String config[:title] else active_admin_config.plural_resource_label