Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portlistr autoconnects even if connection already exists #8

Open
Kunsi opened this issue Jun 2, 2017 · 2 comments
Open

Portlistr autoconnects even if connection already exists #8

Kunsi opened this issue Jun 2, 2017 · 2 comments

Comments

@Kunsi
Copy link

Kunsi commented Jun 2, 2017

Portlister should check if there is already an open connection, if yes, it should not autoconnect.
Note: It's the same printer, so no real problem, however it may cause confusion in the logs.

2017-06-02 08:48:09,617 - octoprint.plugins.portlister - INFO - Checking if /dev/ttyACM0 is in ['/dev/ttyACM0']
2017-06-02 08:48:09,621 - octoprint.plugins.portlister - INFO - autoconnect_delay 20
2017-06-02 08:48:13,178 - octoprint.util.comm - INFO - M110 detected, setting current line number to 0
2017-06-02 08:48:13,190 - octoprint.util.comm - INFO - M110 detected, setting current line number to 0
2017-06-02 08:48:13,211 - octoprint.util.comm - INFO - Printer reports firmware name "Marlin V1; Sprinter/grbl mashup for gen6"
2017-06-02 08:48:29,636 - octoprint.plugins.portlister - INFO - do_auto_connect
2017-06-02 08:48:29,639 - octoprint.plugins.portlister - INFO - realpath match
2017-06-02 08:48:29,642 - octoprint.plugins.portlister - INFO - Attempting to connect to /dev/ttyACM0 at 115200 with profile '_default'
2017-06-02 08:48:30,038 - octoprint.util.comm - INFO - M110 detected, setting current line number to 0
2017-06-02 08:48:30,077 - octoprint.util.comm - INFO - M110 detected, setting current line number to 0
2017-06-02 08:48:30,374 - octoprint.util.comm - INFO - Printer reports firmware name "Marlin V1; Sprinter/grbl mashup for gen6"```
@markwal
Copy link
Owner

markwal commented Jun 3, 2017

Fixed-ish by 0.1.6. There's still a possibility that a connection could have been initiated between the final check added and the reconnect by the plugin, but the window has been reduced dramatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants