Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'event' to 'hangout' #53

Open
annapapitto opened this issue Apr 5, 2018 · 1 comment
Open

Rename 'event' to 'hangout' #53

annapapitto opened this issue Apr 5, 2018 · 1 comment

Comments

@annapapitto
Copy link
Collaborator

I believe that 'event' is an overloaded name. Even my vim editor is telling me that 'event' has special meaning in javascript by coloring and bolding it. In my opinion, naming these 'hangouts' would be more specific and consistent with the command that stores them.

@marwahaha
Copy link
Owner

It's not a reserved word per se, but it is used as a special word in browsers.

I do think the concept of hangout does generalize to event (i.e. exercise, doing laundry, etc), but I like the phrasefriendlog hangout..

I think a PR for this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants