-
Notifications
You must be signed in to change notification settings - Fork 31
Issue with local build and editing pattern files. #363
Comments
@powpow12 when you say "it worked for him" (@isaacchansky) does that mean he was able to successfully edit the file and gulp rebuilt or he was able to reproduce your problem? |
I was able to use PL as normal and edit files/rebuild just fine. |
I'm having the same result as @isaacchansky - If I edit and save I think the best next step is troubleshoot on your machine @powpow12 -- want to do a hangout at some point with me and / or @isaacchansky ?? |
@powpow12 - did you wait 30 seconds before refreshing the page? Gulp triggers a php generate command when html is changed. Gulp will notify you that the new patterns have been built and how long it took to generate them, which is about 30 seconds now. I have seen this before though and have not been able to figure out why it was happening. Sarena's macBook (just hers) fails to generate patterns as well. she has to manually run the php command without the --patternsonly flag "php c:\sandboxes\mayflower\styleguide/core/console --generate --patternsonly" I should note that running that command without the patternsonly flag resets the public folder and removes all of the gulp generated files so you have to run gulp afterwards. |
@jesconstantine @isaacchansky @legostud thanks for the quick follow up. @jesconstantine I think this can wait till I am back in the office tomorrow. I just wanted to get an issue out incase this is a problem people have solved in the past. @legostud I left PL on last night and the test string was still not loaded to the page when I reviewed it this morning. When I run
|
@powpow12 - It seems that some machines have an issue with the --patternsonly flag. Can you try it without that flag 'php core/console --generate'? Make sure to run gulp after it's done. |
@legostud that did not make a difference for me. I went ahead and deleted the repo and re-cloned it. Following the steps in the readme, I still get the above php errors but I went ahead and ran gulp anyways. The only way it seems that I can update mayflower and review the changes is to stop gulp. Run, At least now I have some kind of a workaround. The last time this worked as expected was early last week. I haven't installed or upgraded anything in that time. |
Could it be the version of PHP? I'm running the following. |
@legostud hey just getting time to circle back now. I upgraded to 5.6.30 via this homebrew tutorial. Confirmed that my php version had in fact updated by running
I have the workaround for now but want to keep this opened incase someone else stumbles into the same issue. |
Based on that statement it appears the try catch statement is failing.
|
@legostud I'm getting the same errors. It seems that something is trying to pass .md files to the convertYAML() function, which of course will fail. |
Same issue i faced configuring pattern lab... Can Anyone Help how i can resolve it |
Does it work if you sync to the Master branch? There is a Pattern Lab upgrade that was just released in that branch. |
yesterday, I was trying to troubleshoot a pr but was having a problem updating the pattern locally. Here are my steps:
git pull dev
git checkout feature-branch
cd styleguide
gulp
<h2>Hello</h2>
- saveThis failed for me several times. At first I was concerned that gulp wasn't listening to file changes but we confirmed that it was. Also, there was a possibility I was editing the wrong file but I grep'd the _patterns directory and there were no results suggesting that. Finally, I got @isaacchansky to test locally, and when he did the above steps, PL worked as expected.
The text was updated successfully, but these errors were encountered: