diff --git a/backstopjs/reference/regression_page_ERROR-403_0_document_0_phone.png b/backstopjs/reference/regression_page_ERROR-403_0_document_0_phone.png index 07aadf61f1..5471087c61 100644 Binary files a/backstopjs/reference/regression_page_ERROR-403_0_document_0_phone.png and b/backstopjs/reference/regression_page_ERROR-403_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_ERROR-403_0_document_1_tablet.png b/backstopjs/reference/regression_page_ERROR-403_0_document_1_tablet.png index c448ef96f4..3b0ce72dfc 100644 Binary files a/backstopjs/reference/regression_page_ERROR-403_0_document_1_tablet.png and b/backstopjs/reference/regression_page_ERROR-403_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_ERROR-404_0_document_0_phone.png b/backstopjs/reference/regression_page_ERROR-404_0_document_0_phone.png index a1986b1a61..9ddc29dc6b 100644 Binary files a/backstopjs/reference/regression_page_ERROR-404_0_document_0_phone.png and b/backstopjs/reference/regression_page_ERROR-404_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_ERROR-404_0_document_1_tablet.png b/backstopjs/reference/regression_page_ERROR-404_0_document_1_tablet.png index 98ce3fa086..746b0570dc 100644 Binary files a/backstopjs/reference/regression_page_ERROR-404_0_document_1_tablet.png and b/backstopjs/reference/regression_page_ERROR-404_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_G2G-G2G-ORG-Health-Services_0_document_0_phone.png b/backstopjs/reference/regression_page_G2G-G2G-ORG-Health-Services_0_document_0_phone.png index 8a32717d56..c402bd5642 100644 Binary files a/backstopjs/reference/regression_page_G2G-G2G-ORG-Health-Services_0_document_0_phone.png and b/backstopjs/reference/regression_page_G2G-G2G-ORG-Health-Services_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_G2G-G2G-ORG-Health-Services_0_document_1_tablet.png b/backstopjs/reference/regression_page_G2G-G2G-ORG-Health-Services_0_document_1_tablet.png index 628ccc1cbf..b7e3d1232f 100644 Binary files a/backstopjs/reference/regression_page_G2G-G2G-ORG-Health-Services_0_document_1_tablet.png and b/backstopjs/reference/regression_page_G2G-G2G-ORG-Health-Services_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_G2G-G2G-Service-Unemployment-Benefits_0_document_0_phone.png b/backstopjs/reference/regression_page_G2G-G2G-Service-Unemployment-Benefits_0_document_0_phone.png index 4d066dc280..b313ba4bf4 100644 Binary files a/backstopjs/reference/regression_page_G2G-G2G-Service-Unemployment-Benefits_0_document_0_phone.png and b/backstopjs/reference/regression_page_G2G-G2G-Service-Unemployment-Benefits_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_binder-page-cover_0_document_0_phone.png b/backstopjs/reference/regression_page_binder-page-cover_0_document_0_phone.png index 69483d5d4f..e72eccc711 100644 Binary files a/backstopjs/reference/regression_page_binder-page-cover_0_document_0_phone.png and b/backstopjs/reference/regression_page_binder-page-cover_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_binder-page-internal_0_document_0_phone.png b/backstopjs/reference/regression_page_binder-page-internal_0_document_0_phone.png index 81a67f093c..13800d3a82 100644 Binary files a/backstopjs/reference/regression_page_binder-page-internal_0_document_0_phone.png and b/backstopjs/reference/regression_page_binder-page-internal_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_detail-for-service-howto-location_0_document_0_phone.png b/backstopjs/reference/regression_page_detail-for-service-howto-location_0_document_0_phone.png index 3eb03d4192..9bb9e0ca2b 100644 Binary files a/backstopjs/reference/regression_page_detail-for-service-howto-location_0_document_0_phone.png and b/backstopjs/reference/regression_page_detail-for-service-howto-location_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_detail-for-service-howto-location_0_document_1_tablet.png b/backstopjs/reference/regression_page_detail-for-service-howto-location_0_document_1_tablet.png index 25ab811090..6b12d82cc6 100644 Binary files a/backstopjs/reference/regression_page_detail-for-service-howto-location_0_document_1_tablet.png and b/backstopjs/reference/regression_page_detail-for-service-howto-location_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_event-end-date-with-time_0_document_0_phone.png b/backstopjs/reference/regression_page_event-end-date-with-time_0_document_0_phone.png index faa3dd4ea7..52f0e9741b 100644 Binary files a/backstopjs/reference/regression_page_event-end-date-with-time_0_document_0_phone.png and b/backstopjs/reference/regression_page_event-end-date-with-time_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_event-end-date_0_document_0_phone.png b/backstopjs/reference/regression_page_event-end-date_0_document_0_phone.png index 3358a9f71d..dfa22b5172 100644 Binary files a/backstopjs/reference/regression_page_event-end-date_0_document_0_phone.png and b/backstopjs/reference/regression_page_event-end-date_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_event-listing_0_document_0_phone.png b/backstopjs/reference/regression_page_event-listing_0_document_0_phone.png index 8955c464ec..abb068c903 100644 Binary files a/backstopjs/reference/regression_page_event-listing_0_document_0_phone.png and b/backstopjs/reference/regression_page_event-listing_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_event-public-meeting-agenda_0_document_1_tablet.png b/backstopjs/reference/regression_page_event-public-meeting-agenda_0_document_1_tablet.png index 1523150ea3..94d4d540cf 100644 Binary files a/backstopjs/reference/regression_page_event-public-meeting-agenda_0_document_1_tablet.png and b/backstopjs/reference/regression_page_event-public-meeting-agenda_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_event-public-meeting-minutes_0_document_1_tablet.png b/backstopjs/reference/regression_page_event-public-meeting-minutes_0_document_1_tablet.png index 91bf79269e..6222513d21 100644 Binary files a/backstopjs/reference/regression_page_event-public-meeting-minutes_0_document_1_tablet.png and b/backstopjs/reference/regression_page_event-public-meeting-minutes_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_event-recurring_0_document_0_phone.png b/backstopjs/reference/regression_page_event-recurring_0_document_0_phone.png index 73fa83a06d..b53b8900a7 100644 Binary files a/backstopjs/reference/regression_page_event-recurring_0_document_0_phone.png and b/backstopjs/reference/regression_page_event-recurring_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_event_0_document_0_phone.png b/backstopjs/reference/regression_page_event_0_document_0_phone.png index 39ef4879da..f73b93263c 100644 Binary files a/backstopjs/reference/regression_page_event_0_document_0_phone.png and b/backstopjs/reference/regression_page_event_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_executive-order_0_document_0_phone.png b/backstopjs/reference/regression_page_executive-order_0_document_0_phone.png index 6886bfca50..50f03078d1 100644 Binary files a/backstopjs/reference/regression_page_executive-order_0_document_0_phone.png and b/backstopjs/reference/regression_page_executive-order_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_guide-section-all-fields_0_document_0_phone.png b/backstopjs/reference/regression_page_guide-section-all-fields_0_document_0_phone.png index c5625493fb..0d9e2c169d 100644 Binary files a/backstopjs/reference/regression_page_guide-section-all-fields_0_document_0_phone.png and b/backstopjs/reference/regression_page_guide-section-all-fields_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_guide-section-all-fields_0_document_1_tablet.png b/backstopjs/reference/regression_page_guide-section-all-fields_0_document_1_tablet.png index f6c3a69ee1..21ecba556b 100644 Binary files a/backstopjs/reference/regression_page_guide-section-all-fields_0_document_1_tablet.png and b/backstopjs/reference/regression_page_guide-section-all-fields_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_guide_0_document_0_phone.png b/backstopjs/reference/regression_page_guide_0_document_0_phone.png index b85df6863e..5a5bcc1ee4 100644 Binary files a/backstopjs/reference/regression_page_guide_0_document_0_phone.png and b/backstopjs/reference/regression_page_guide_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_guide_0_document_1_tablet.png b/backstopjs/reference/regression_page_guide_0_document_1_tablet.png index bb7fbcbaf1..41d915a1ad 100644 Binary files a/backstopjs/reference/regression_page_guide_0_document_1_tablet.png and b/backstopjs/reference/regression_page_guide_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_information-details-preContent-media_0_document_0_phone.png b/backstopjs/reference/regression_page_information-details-preContent-media_0_document_0_phone.png index c2a81ee9e2..929e684d7d 100644 Binary files a/backstopjs/reference/regression_page_information-details-preContent-media_0_document_0_phone.png and b/backstopjs/reference/regression_page_information-details-preContent-media_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_information-details_0_document_0_phone.png b/backstopjs/reference/regression_page_information-details_0_document_0_phone.png index 1508523a26..b66fbbed42 100644 Binary files a/backstopjs/reference/regression_page_information-details_0_document_0_phone.png and b/backstopjs/reference/regression_page_information-details_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_location-listing_0_document_0_phone.png b/backstopjs/reference/regression_page_location-listing_0_document_0_phone.png index 00bbc8c541..9bbb5c8331 100644 Binary files a/backstopjs/reference/regression_page_location-listing_0_document_0_phone.png and b/backstopjs/reference/regression_page_location-listing_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_location-listing_0_document_1_tablet.png b/backstopjs/reference/regression_page_location-listing_0_document_1_tablet.png index 99f0c87fbf..512916bce6 100644 Binary files a/backstopjs/reference/regression_page_location-listing_0_document_1_tablet.png and b/backstopjs/reference/regression_page_location-listing_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_location-park-content_0_document_0_phone.png b/backstopjs/reference/regression_page_location-park-content_0_document_0_phone.png index 6ddd0f68d6..d8470eca4e 100644 Binary files a/backstopjs/reference/regression_page_location-park-content_0_document_0_phone.png and b/backstopjs/reference/regression_page_location-park-content_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_location-park-content_0_document_1_tablet.png b/backstopjs/reference/regression_page_location-park-content_0_document_1_tablet.png index 40d6695296..f16e3f1c85 100644 Binary files a/backstopjs/reference/regression_page_location-park-content_0_document_1_tablet.png and b/backstopjs/reference/regression_page_location-park-content_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_organization-boards_0_document_0_phone.png b/backstopjs/reference/regression_page_organization-boards_0_document_0_phone.png index 5e0a531686..4be8f373dd 100644 Binary files a/backstopjs/reference/regression_page_organization-boards_0_document_0_phone.png and b/backstopjs/reference/regression_page_organization-boards_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_organization-boards_0_document_1_tablet.png b/backstopjs/reference/regression_page_organization-boards_0_document_1_tablet.png index 6ffd2fe852..9425097c44 100644 Binary files a/backstopjs/reference/regression_page_organization-boards_0_document_1_tablet.png and b/backstopjs/reference/regression_page_organization-boards_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_organization-elected-official_0_document_0_phone.png b/backstopjs/reference/regression_page_organization-elected-official_0_document_0_phone.png index 7c51a03c6f..79b296bc94 100644 Binary files a/backstopjs/reference/regression_page_organization-elected-official_0_document_0_phone.png and b/backstopjs/reference/regression_page_organization-elected-official_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_organization-elected-official_0_document_1_tablet.png b/backstopjs/reference/regression_page_organization-elected-official_0_document_1_tablet.png index 0203407002..1ffe800a16 100644 Binary files a/backstopjs/reference/regression_page_organization-elected-official_0_document_1_tablet.png and b/backstopjs/reference/regression_page_organization-elected-official_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_organization_0_document_0_phone.png b/backstopjs/reference/regression_page_organization_0_document_0_phone.png index 3dfe5181ca..87b9c012b7 100644 Binary files a/backstopjs/reference/regression_page_organization_0_document_0_phone.png and b/backstopjs/reference/regression_page_organization_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_organization_0_document_1_tablet.png b/backstopjs/reference/regression_page_organization_0_document_1_tablet.png index 6e0a1d5c60..7fcbd6a6b9 100644 Binary files a/backstopjs/reference/regression_page_organization_0_document_1_tablet.png and b/backstopjs/reference/regression_page_organization_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_press-listing_0_document_0_phone.png b/backstopjs/reference/regression_page_press-listing_0_document_0_phone.png index bfde24bc09..6a8810d315 100644 Binary files a/backstopjs/reference/regression_page_press-listing_0_document_0_phone.png and b/backstopjs/reference/regression_page_press-listing_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_press-listing_0_document_1_tablet.png b/backstopjs/reference/regression_page_press-listing_0_document_1_tablet.png index bf33397de6..e9642f7f90 100644 Binary files a/backstopjs/reference/regression_page_press-listing_0_document_1_tablet.png and b/backstopjs/reference/regression_page_press-listing_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_press-release-with-image_0_document_1_tablet.png b/backstopjs/reference/regression_page_press-release-with-image_0_document_1_tablet.png index 74bc089ef6..65dd781501 100644 Binary files a/backstopjs/reference/regression_page_press-release-with-image_0_document_1_tablet.png and b/backstopjs/reference/regression_page_press-release-with-image_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_press-release-with-video_0_document_1_tablet.png b/backstopjs/reference/regression_page_press-release-with-video_0_document_1_tablet.png index 140a8e75a9..304369f225 100644 Binary files a/backstopjs/reference/regression_page_press-release-with-video_0_document_1_tablet.png and b/backstopjs/reference/regression_page_press-release-with-video_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_press-release_0_document_1_tablet.png b/backstopjs/reference/regression_page_press-release_0_document_1_tablet.png index 41d0dfbc82..ac91c2e037 100644 Binary files a/backstopjs/reference/regression_page_press-release_0_document_1_tablet.png and b/backstopjs/reference/regression_page_press-release_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_section-landing_0_document_0_phone.png b/backstopjs/reference/regression_page_section-landing_0_document_0_phone.png index b125d800c3..be2b63fa2a 100644 Binary files a/backstopjs/reference/regression_page_section-landing_0_document_0_phone.png and b/backstopjs/reference/regression_page_section-landing_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_section-landing_0_document_1_tablet.png b/backstopjs/reference/regression_page_section-landing_0_document_1_tablet.png index 071696c2f2..e103a7e2cf 100644 Binary files a/backstopjs/reference/regression_page_section-landing_0_document_1_tablet.png and b/backstopjs/reference/regression_page_section-landing_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_service_0_document_0_phone.png b/backstopjs/reference/regression_page_service_0_document_0_phone.png index deb2d613da..c8e3b9c58a 100644 Binary files a/backstopjs/reference/regression_page_service_0_document_0_phone.png and b/backstopjs/reference/regression_page_service_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_topic-your-government_0_document_0_phone.png b/backstopjs/reference/regression_page_topic-your-government_0_document_0_phone.png index 132eb01814..64f9ea3827 100644 Binary files a/backstopjs/reference/regression_page_topic-your-government_0_document_0_phone.png and b/backstopjs/reference/regression_page_topic-your-government_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_page_topic-your-government_0_document_1_tablet.png b/backstopjs/reference/regression_page_topic-your-government_0_document_1_tablet.png index 708a895143..41894b5d5f 100644 Binary files a/backstopjs/reference/regression_page_topic-your-government_0_document_1_tablet.png and b/backstopjs/reference/regression_page_topic-your-government_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_page_topic_0_document_0_phone.png b/backstopjs/reference/regression_page_topic_0_document_0_phone.png index 0f413d87d8..6bd51c948c 100644 Binary files a/backstopjs/reference/regression_page_topic_0_document_0_phone.png and b/backstopjs/reference/regression_page_topic_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_template_01-content-types-binder-page_0_document_0_phone.png b/backstopjs/reference/regression_template_01-content-types-binder-page_0_document_0_phone.png index 0784c8297d..1f9e48b18b 100644 Binary files a/backstopjs/reference/regression_template_01-content-types-binder-page_0_document_0_phone.png and b/backstopjs/reference/regression_template_01-content-types-binder-page_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_template_01-content-types-event_0_document_0_phone.png b/backstopjs/reference/regression_template_01-content-types-event_0_document_0_phone.png index 26e81fbf58..2f42eebbaf 100644 Binary files a/backstopjs/reference/regression_template_01-content-types-event_0_document_0_phone.png and b/backstopjs/reference/regression_template_01-content-types-event_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_template_01-content-types-policy-advisory_0_document_0_phone.png b/backstopjs/reference/regression_template_01-content-types-policy-advisory_0_document_0_phone.png index 8aaff940f0..6309d89d3f 100644 Binary files a/backstopjs/reference/regression_template_01-content-types-policy-advisory_0_document_0_phone.png and b/backstopjs/reference/regression_template_01-content-types-policy-advisory_0_document_0_phone.png differ diff --git a/backstopjs/reference/regression_template_01-content-types-press_0_document_1_tablet.png b/backstopjs/reference/regression_template_01-content-types-press_0_document_1_tablet.png index 7d55673ab0..06e3ce2ff5 100644 Binary files a/backstopjs/reference/regression_template_01-content-types-press_0_document_1_tablet.png and b/backstopjs/reference/regression_template_01-content-types-press_0_document_1_tablet.png differ diff --git a/backstopjs/reference/regression_template_01-content-types-services_0_document_0_phone.png b/backstopjs/reference/regression_template_01-content-types-services_0_document_0_phone.png index 6cc5aae065..09e1f73dd5 100644 Binary files a/backstopjs/reference/regression_template_01-content-types-services_0_document_0_phone.png and b/backstopjs/reference/regression_template_01-content-types-services_0_document_0_phone.png differ diff --git a/changelogs/DP-8645.txt b/changelogs/DP-8645.txt new file mode 100644 index 0000000000..f2d868ddd9 --- /dev/null +++ b/changelogs/DP-8645.txt @@ -0,0 +1,3 @@ +Changed +Patch +- DP-8645: Remove non-breaking space from decorative link markup \ No newline at end of file diff --git a/styleguide/source/_patterns/01-atoms/decorative-link.twig b/styleguide/source/_patterns/01-atoms/decorative-link.twig index a0495ce730..f8f9ad894e 100644 --- a/styleguide/source/_patterns/01-atoms/decorative-link.twig +++ b/styleguide/source/_patterns/01-atoms/decorative-link.twig @@ -2,5 +2,5 @@ {{decorativeLink.text}} {{ icon('arrow') }} + title="{{ decorativeLink.info }}">{{decorativeLink.text}}{{ icon('arrow') }} diff --git a/styleguide/source/assets/scss/00-base/mixins/_ma-link-decorative.scss b/styleguide/source/assets/scss/00-base/mixins/_ma-link-decorative.scss index a48b9228a6..552795d0e8 100644 --- a/styleguide/source/assets/scss/00-base/mixins/_ma-link-decorative.scss +++ b/styleguide/source/assets/scss/00-base/mixins/_ma-link-decorative.scss @@ -1,10 +1,9 @@ // applied to the container holding the a tag // adds a underline on hover // prevents the external or arrow icon from becoming an orphan -// basic structure expected =>
text 
+// with an absolutely positioned link icon @mixin ma-link-decorative { - padding-right: .8em; a { @include ma-link-underline; @@ -12,9 +11,11 @@ svg { display: inline-block; + position: absolute; + bottom: 5px; height: .6em; - margin-right: -.8em; width: .6em; + margin-left: 0.25em; } } } \ No newline at end of file diff --git a/styleguide/source/assets/scss/01-atoms/_decorative-link.scss b/styleguide/source/assets/scss/01-atoms/_decorative-link.scss index f6ac183193..c9c34f1a6e 100644 --- a/styleguide/source/assets/scss/01-atoms/_decorative-link.scss +++ b/styleguide/source/assets/scss/01-atoms/_decorative-link.scss @@ -1,6 +1,8 @@ .ma__decorative-link { @include ma-link-decorative; + position: relative; display: inline-block; vertical-align: middle; + padding-right: 0.8rem; width: 100%; } diff --git a/styleguide/source/assets/scss/03-organisms/_icon-links.scss b/styleguide/source/assets/scss/03-organisms/_icon-links.scss index f56e9c7966..e14f8da71e 100644 --- a/styleguide/source/assets/scss/03-organisms/_icon-links.scss +++ b/styleguide/source/assets/scss/03-organisms/_icon-links.scss @@ -11,8 +11,8 @@ &__icon { font-size: 0; position: absolute; - top: 5px; - left: 0; + top: 8px; + left: 0; & > svg { height: 18px;