Fix few docs tickets #448
Fix few docs tickets #448
Conversation
tapaswenipathak
changed the title
|
Thanks @tapaswenipathak ! Sorry for the slow response, just got back from vacation. I'll take a look shortly |
|
@jwilander Quick reminder to review updates when you have the chance :) |
|
Thanks :) I'll look soon |
|
This issue has been automatically labelled "stale" because it hasn't had recent activity. /cc @jasonblais @hanzei |
|
@jwilander Does the doc look ok? If this doc looks ok, I will create a PR adding remaining things. |
| 'IsLicensed': '<true/false>' | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This one should have a seq_id and broadcast right?
There was a problem hiding this comment.
Co-Authored-By: Joram Wilander <[email protected]>
Co-Authored-By: Joram Wilander <[email protected]>
|
@tapaswenipathak update your PR with the latest master |
|
This issue has been automatically labelled "stale" because it hasn't had recent activity. /cc @jasonblais @hanzei |
|
@jwilander gentle reminder to give this another look |
| 'update_at': '<timestamp>', | ||
| 'delete_at': '<timestamp>', | ||
| 'team_id': '<team_id>', | ||
| 'type': 'O', |
There was a problem hiding this comment.
This can be 'P', 'D' or 'G' as well
| 'type': 'O', | ||
| 'display_name':'<channel_id>', | ||
| 'name': '<channel_name>', | ||
| 'header': 'header', |
There was a problem hiding this comment.
This should be a blank string right?
| 'header': 'header', | ||
| 'purpose': '', | ||
| 'last_post_at': '<timestamp>', | ||
| 'total_msg_count': '<total_msg_count>', |
There was a problem hiding this comment.
There shouldn't be quotes here as this is a number. Same with the timestamp fields
There was a problem hiding this comment.
There's a lot of other cases throughout the changes with this issue
|
Hi @tapaswenipathak. Looks like this ticket has not made much progress and there may be outstanding issues. After following up with the team, we think it may be best to close the PR at this time. We recommend potentially spending some additional time with our code base and proposing smaller PRs for changes in the future. We appreciate the time you put into this project. |
|
On Wed, 4 Sep 2019, 02:21 Katie Wiersgalla, ***@***.***> wrote:
Hi @tapaswenipathak <https://github.com/tapaswenipathak>. Looks like this
ticket has not made much progress and there may be outstanding issues.
After following up with the team, we think it may be best to close the PR
at this time. We recommend potentially spending some additional time with
our code base and proposing smaller PRs for changes in the future. We
appreciate the time you put into this project.
Hello, feel free deciding with your colleague and taking action.
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#448?email_source=notifications&email_token=AA7TVIVIW34P5NQNWPFNZGDQH3E6LA5CNFSM4HPXDLY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ZRCTQ#issuecomment-527634766>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA7TVIXBU6RZ6UXMXESHSDDQH3E6LANCNFSM4HPXDLYQ>
.
|
|
Closing pull request. |
Fix #429.
Fix #430.
As I am GSoD'19 applicant, prev