You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello @mattrubin and thanks for building this awesome library.
We want to use your lib in a project with some different needs for the Keychain storage implementation.
I have already implemented the lib with our own library for Keychain persistance and works great, although I had to manually add the files into my project in order I skip the Keychain.swift.
Would you accept a PR that adds a new subspec for CocoaPods without Keychain lib?
You can check what I mean here
The text was updated successfully, but these errors were encountered:
I'd be happy to take a look at a PR adding a subspec. I'm curious, though, why it's necessary. Does including the keychain functionality of the current library cause problems, or are you simply trying to avoid including code you never use?
Thanks a lot for welcoming a PR. I want to avoid including the code as I don’t use it.
I have already played with it, but the current version of CocoaPods breaks the CommonCrypto handling. I will have a look and make a PR once ready. :)
I'd be happy to take a look at a PR adding a subspec. I'm curious, though, why it's necessary. Does including the keychain functionality of the current library cause problems, or are you simply trying to avoid including code you never use?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/114#issuecomment-262274290, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAw_jJ6CBDB5biaobiT-K28wyME9dd6qks5rAwxegaJpZM4K5F6D.
Hello @mattrubin and thanks for building this awesome library.
We want to use your lib in a project with some different needs for the Keychain storage implementation.
I have already implemented the lib with our own library for Keychain persistance and works great, although I had to manually add the files into my project in order I skip the
Keychain.swift
.Would you accept a PR that adds a new subspec for CocoaPods without Keychain lib?
You can check what I mean here
The text was updated successfully, but these errors were encountered: