From 7d64db7038afa5d7727d94a03a072799f65af029 Mon Sep 17 00:00:00 2001 From: Julian Oes Date: Thu, 21 Nov 2024 10:15:25 +1300 Subject: [PATCH] core: remove way too verbose warnings These warnings should just be debug statements, as it is entirely likely to see FTP traffic from other systems and components. --- src/mavsdk/core/mavlink_ftp_client.cpp | 8 ++++++-- src/mavsdk/core/mavlink_ftp_server.cpp | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/mavsdk/core/mavlink_ftp_client.cpp b/src/mavsdk/core/mavlink_ftp_client.cpp index 754442fcbe..c2cdce698a 100644 --- a/src/mavsdk/core/mavlink_ftp_client.cpp +++ b/src/mavsdk/core/mavlink_ftp_client.cpp @@ -107,13 +107,17 @@ void MavlinkFtpClient::process_mavlink_ftp_message(const mavlink_message_t& msg) mavlink_msg_file_transfer_protocol_decode(&msg, &ftp_req); if (ftp_req.target_system != 0 && ftp_req.target_system != _system_impl.get_own_system_id()) { - LogWarn() << "Received FTP with wrong target system ID!"; + if (_debugging) { + LogDebug() << "Received FTP message with wrong target system ID"; + } return; } if (ftp_req.target_component != 0 && ftp_req.target_component != _system_impl.get_own_component_id()) { - LogWarn() << "Received FTP with wrong target component ID!"; + if (_debugging) { + LogDebug() << "Received FTP message with wrong target component ID"; + } return; } diff --git a/src/mavsdk/core/mavlink_ftp_server.cpp b/src/mavsdk/core/mavlink_ftp_server.cpp index cd236a2017..c48d00bb2b 100644 --- a/src/mavsdk/core/mavlink_ftp_server.cpp +++ b/src/mavsdk/core/mavlink_ftp_server.cpp @@ -45,13 +45,17 @@ void MavlinkFtpServer::process_mavlink_ftp_message(const mavlink_message_t& msg) if (ftp_req.target_system != 0 && ftp_req.target_system != _server_component_impl.get_own_system_id()) { - LogWarn() << "wrong sysid!"; + if (_debugging) { + LogDebug() << "Received FTP message with wrong target system ID"; + } return; } if (ftp_req.target_component != 0 && ftp_req.target_component != _server_component_impl.get_own_component_id()) { - LogWarn() << "wrong compid!"; + if (_debugging) { + LogDebug() << "Received FTP message with wrong target component ID"; + } return; }