Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should use HTTPS to download source code #5

Open
xtaran opened this issue Sep 23, 2020 · 0 comments
Open

Should use HTTPS to download source code #5

xtaran opened this issue Sep 23, 2020 · 0 comments

Comments

@xtaran
Copy link

xtaran commented Sep 23, 2020

You should use HTTPS here:

acme.sh-debian/debian/rules

Line 26 in 82a3d2a

wget -P debian/tmp http://github.com/$(GITHUBUSER)/$(PROJECT)/archive/$(BRANCH).tar.gz

Github redirects to HTTPS, but some man in the middle could still intercept this and redirect you elsewhere before that happens.
vincib added a commit to octopuce/acme.sh-debian that referenced this issue Oct 7, 2021
@vincib
[dev] replace github download by https, fixes mdbraber#5
713b0f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xtaran