Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add glossary term 'escaping text' #37444

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add glossary term 'escaping text' #37444

wants to merge 4 commits into from
+35 −4

Conversation

PassionPenguin
Copy link
Contributor

Description

This may fixes #37206.

The addition mainly talks about the escape character and the escape sequence with several examples in HTML, CSS, JavaScript and URLs.

@PassionPenguin PassionPenguin requested review from a team as code owners December 30, 2024 06:19
@PassionPenguin PassionPenguin requested review from estelle and hamishwillee and removed request for a team December 30, 2024 06:19
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries size/s [PR only] 6-50 LoC changed labels Dec 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024 •
edited
Loading

Preview URLs

Flaws (48)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/ident
Title: <ident>
Flaw count: 48

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted
External URLs (2)

URL: /en-US/docs/Glossary/Escaping_Text
Title: Escaping Text

(comment last updated: 2024-12-31 12:37:16)

estelle
estelle reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few grammar nits and a see also reorder

files/en-us/glossary/character_reference/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/escaping_text/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/escaping_text/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/escaping_text/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/escaping_text/index.md Outdated Show resolved Hide resolved
Josh-Cena
Josh-Cena reviewed Dec 30, 2024
View reviewed changes
files/en-us/glossary/escaping_text/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/escaping_text/index.md
@@ -0,0 +1,25 @@
---
title: Escaping Text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A glossary title should be a concrete term, not a concept. I recommend either "escape character" or "escape sequence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same idea, though not sure which one to choose, so i pick the one the issue title suggested

@estelle what's your opinion on this name?

files/en-us/glossary/escaping_text/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/escaping_text/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/escaping_text/index.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@estelle estelle estelle left review comments

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write a glossary page on "escaping text"
3 participants
@PassionPenguin @estelle @Josh-Cena