You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
After a quick scan I'd say this code looks well-isolated enough, with lots of test cases, that Eric could take this task on. The package could just assume the the input is already a python str and eliminate the decode_object_from_bytes_if_needed call.
Users (if any) will probably want to use their own user agent (web client) and logging for the module, so we could encapsulate this functionality in separate classes, provide default implementations (with requests / urllib3 and logging respectively), and make them configurable, e.g.:
classCustomLogger(AbstractLogger):
definfo(self, message: str) ->None:
logging.info(message)
defdebug(self, message: str) ->None:
logging.debug(message)
# ...# Another class implementing AbstractUserAgent's interfacenormalized_url=normalize_url(url=url, logger=CustomLogger(), ua=CustomUserAgent())
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As decided in today's tech meeting, I'm transferring this task into an issue.
The text was updated successfully, but these errors were encountered: