Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError #55

Closed
bcail opened this issue Nov 30, 2016 · 7 comments · Fixed by #56
Closed

Uncaught TypeError #55

bcail opened this issue Nov 30, 2016 · 7 comments · Fixed by #56

Comments

@bcail
Copy link

bcail commented Nov 30, 2016

@mejackreed
Copy link
Owner

Thanks for reporting @bcail . I'm looking into it.

@mejackreed
Copy link
Owner

@bcail The issue seems to stem from the fact that https://repository.library.brown.edu/iiif/image/bdr:597184/info.json is reporting a potentially conflicting tileSize.

screen shot 2016-12-05 at 8 35 19 am

There is also a bug in Leaflet-IIIF where an explicit tileSize declaration is not being honored. A PR is coming soon to fix this.

@mejackreed
Copy link
Owner

@bcail #56 should fix your issue, I'll cut a new release soon. In the meantime, you may want to look into why your preferred tileSize is reporting that large of a width. That might also be problematic.

@bcail
Copy link
Author

bcail commented Dec 5, 2016

Thanks, @mejackreed, for fixing the issue & pointing out the issue with our IIIF info.

@bcail
Copy link
Author

bcail commented Dec 5, 2016

@mejackreed thanks for the release as well. Unfortunately, I'm still getting the same error (on line 94, in the _fitBounds function). Is that supposed to be working now?

@mejackreed
Copy link
Owner

mejackreed commented Dec 5, 2016

@bcail you will need to specify an explicit tileSize when instantiating the layer since your width/height is most likely incompatible with the info.json "tile" section: https://jsfiddle.net/mejackreed/r3cfaej8/

@bcail
Copy link
Author

bcail commented Dec 5, 2016

thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants