Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement user self service api for user detail information #3723 #3809

Merged
merged 3 commits into from
Jan 17, 2025
Merged

implement user self service api for user detail information #3723 #3809

merged 3 commits into from
Jan 17, 2025

Conversation

hamidonos
Copy link
Collaborator

lorriborri
lorriborri requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@lorriborri lorriborri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Good work! ⭐ 🦉

I found only one minor issue and some optional issues you might want to look at:

Minor Issue:

  • usage of primitives in data transfer objects

Optional Issues:

  • NullPointer proove
  • Mockito verify tests

.../src/main/java/com/mercedesbenz/sechub/domain/administration/user/UserDetailInformation.java Show resolved Hide resolved
.../src/main/java/com/mercedesbenz/sechub/domain/administration/user/UserDetailInformation.java Show resolved Hide resolved
...ava/com/mercedesbenz/sechub/domain/administration/user/UserDetailInformationServiceTest.java Show resolved Hide resolved
@lorriborri
Copy link
Member

And if you want to fix the build, you need to fix the UserRestControllerRestDocTest: use instead of the AuthenticationHelper, the TestAuthenticationHelper (It was renamed in the ArchUnit fix) 🙂

@lorriborri lorriborri self-requested a review January 17, 2025 12:26
lorriborri
lorriborri approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@lorriborri lorriborri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! Well done! ⭐ 🐘

@hamidonos hamidonos merged commit 8eac1eb into develop Jan 17, 2025
2 checks passed
@hamidonos hamidonos deleted the feature-fetch-user-profile-web-ui-3723 branch January 17, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorriborri lorriborri lorriborri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add New API Call for User Profile
2 participants
@hamidonos @lorriborri