Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TOTP seed handling #3785 #3787

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fix TOTP seed handling #3785 #3787

wants to merge 6 commits into from

Conversation

winzj
Copy link
Member

@winzj winzj commented Jan 13, 2025

@winzj winzj marked this pull request as ready for review January 15, 2025 07:00
@winzj winzj requested a review from de-jcup January 15, 2025 08:23
de-jcup
de-jcup requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but I have found some parts which should be changed.

sechub-wrapper-owasp-zap/README.adoc Outdated Show resolved Hide resolved
...ain/java/com/mercedesbenz/sechub/zapwrapper/scan/login/MissingMandatoryBindingException.java Outdated Show resolved Hide resolved
.../main/java/com/mercedesbenz/sechub/zapwrapper/scan/login/ZapWrapperGroovyScriptExecutor.java Outdated Show resolved Hide resolved
.../main/java/com/mercedesbenz/sechub/zapwrapper/scan/login/ZapWrapperGroovyScriptExecutor.java Outdated Show resolved Hide resolved
...b-wrapper-owasp-zap/src/main/java/com/mercedesbenz/sechub/zapwrapper/util/TOTPGenerator.java Outdated Show resolved Hide resolved
...t/java/com/mercedesbenz/sechub/zapwrapper/scan/login/ZapWrapperGroovyScriptExecutorTest.java Show resolved Hide resolved
...t/java/com/mercedesbenz/sechub/zapwrapper/scan/login/ZapWrapperGroovyScriptExecutorTest.java Outdated Show resolved Hide resolved
...apper-owasp-zap/src/test/java/com/mercedesbenz/sechub/zapwrapper/util/TOTPGeneratorTest.java Outdated Show resolved Hide resolved
...apper-owasp-zap/src/test/java/com/mercedesbenz/sechub/zapwrapper/util/TOTPGeneratorTest.java Outdated Show resolved Hide resolved
...apper-owasp-zap/src/test/resources/login-script-examples/test-script-custom-exception.groovy Outdated Show resolved Hide resolved
@winzj winzj requested a review from de-jcup January 15, 2025 13:37
de-jcup
de-jcup approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good - let's merge it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-jcup de-jcup de-jcup approved these changes

Assignees

@de-jcup de-jcup

@winzj winzj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix TOTP seed handling inside ZAP wrapper
2 participants
@winzj @de-jcup