Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.7 has some seriously breaking changes from 1.0.5 #19

Open
zackdotcomputer opened this issue Mar 23, 2022 · 1 comment
Open

Comments

@zackdotcomputer
Copy link

zackdotcomputer commented Mar 23, 2022

Performing a minor npm update on my project automatically updated 1.0.5 to 1.0.7. However, 1.0.7 introduced breaking changes to the type signatures of several functions. It probably should have been a 1.1.0 and marked as containing breaking changes.

I ran into two breaking issues personally, but I assume there were more:

  • All of the exported SomethingEnums are no longer enums?? The proper enum has been renamed from X to XExpected and the name X is now XEnum | string, which breaks any use of the enums that depended on them being enums. (Additionally, the enums are less useful now since they're basically defined as "one of these strings, unless its not in which case it could be any string.")
  • The method signature for candidatesList is substantially different, dropping emailAddresses and tag while adding includeDeleteData (I'm just lucky the number of arguments changed, otherwise my code would have kept calling it and it would have just mysteriously broken!)
@zackdotcomputer
Copy link
Author

Ha well here I am 6 months later and I forgot about this and tried to update the package again. I note that this package is still using the patch-tier semver to push backwards-incompatible versions, now up to 1.0.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant