Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade statichcheck-action to v1.3.0 across all repos #13041

Open
devhindo opened this issue Dec 28, 2024 · 6 comments · May be fixed by meshery/meshery-nginx-sm#294, meshery/meshery-kuma#448, meshery/meshery-app-mesh#161, meshery/meshery-traefik-mesh#314 or meshery/meshery-kuma#449
Open

upgrade statichcheck-action to v1.3.0 across all repos #13041

devhindo opened this issue Dec 28, 2024 · 6 comments · May be fixed by meshery/meshery-nginx-sm#294, meshery/meshery-kuma#448, meshery/meshery-app-mesh#161, meshery/meshery-traefik-mesh#314 or meshery/meshery-kuma#449
Assignees
@Deeptanshu-sankhwar
Labels
good first issue Good for newcomers kind/bug Something isn't working

Comments

@devhindo
Copy link
Member

devhindo commented Dec 28, 2024 •
edited
Loading

dominikh/[email protected] should be upgraded across all repos wherever it's used to v1.3.0 with these configurations:

      - uses: dominikh/[email protected]
        with:
          version: "latest"
          install-go: false

which is part of the static check workflow:

  static_check:
    name: Static check
    runs-on: ubuntu-latest
    steps:
      - name: Check out code
        uses: actions/checkout@master
        with:
          fetch-depth: 1
      - name: Setup Go
        uses: actions/setup-go@v5
        with:
          go-version: 1.23
      - uses: dominikh/[email protected]
        with:
          version: "latest"
          install-go: false
@devhindo devhindo added kind/bug Something isn't working good first issue Good for newcomers labels Dec 28, 2024
@devhindo devhindo changed the title upgrade statichcheck-action to v1.3.0 accross all repoes upgrade statichcheck-action to v1.3.0 across all repos Dec 28, 2024
@doppedheart
Copy link

i wanted to work on this can you assign me this?

@pratikgitss
Copy link

I am not able to find the static check workflow can we get an example?

@devhindo
Copy link
Member Author

devhindo commented Dec 29, 2024 •
edited
Loading

@doppedheart @pratikgitss I recently fixed it here in meshery-cilium in this pr https://github.com/meshery/meshery-cilium/pull/173/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f

@Deeptanshu-sankhwar
Copy link

Yes @devhindo . Thanks for sharing it, I believe this repo doesn't use staticcheck-action but there are other adaptor repos which do use it and need the update in their workflows. Let me raise a PR on whichever adaptor repository the updated is needed.

Thanks

@devhindo
Copy link
Member Author

yeah you're right, wherever this is used in any of the other adapters this should be updated @Deeptanshu-sankhwar

This was referenced Dec 29, 2024
Open
Open
Open
Open
@Deeptanshu-sankhwar
Copy link

Hello @devhindo , I believe I have made the upgrade to all the possible go repositories across meshery which were using staticcheck-action in their workflows, as can also be seen at https://github.com/orgs/meshery/repositories?q=lang%3Ago&type=all.

Please review the changes made to those above 4 repositories.

Thanks!

This was referenced Dec 30, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Deeptanshu-sankhwar Deeptanshu-sankhwar

Labels
good first issue Good for newcomers kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@Deeptanshu-sankhwar @devhindo @doppedheart @pratikgitss