Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move_field same name from string to object #599

Open
TobiasNx opened this issue Jan 4, 2022 · 4 comments
Open

move_field same name from string to object #599

TobiasNx opened this issue Jan 4, 2022 · 4 comments
Assignees
@fsteeg
Labels
Conform To Catmandu Metafix

Comments

@TobiasNx
Copy link
Contributor

TobiasNx commented Jan 4, 2022

See here

If we use move_field on a field to give it a hirachie and move the valure in a not existing subfield you recive an error.

move_field(license, license.id)
TobiasNx referenced this issue in TobiasNx/fix-FunctionalReview-Testing Feb 1, 2022
@TobiasNx
Add test for moving a field to its own subfield
a2652d3 
https://github.com/metafacture/metafacture-fix/issues/104
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Feb 1, 2022

Added a test scenario for this:
TobiasNx/fix-FunctionalReview-Testing@a2652d3

Breaks.
should be:

{
	"fictional": {
		"animal": "unicorn"
	}
}

@fsteeg
Copy link
Member

fsteeg commented Feb 3, 2022

Functional review: @TobiasNx
Code review: @blackwinter

@fsteeg fsteeg self-assigned this Feb 3, 2022
@TobiasNx TobiasNx changed the title move_field same name from string to object move_field same name from string to object Feb 8, 2022
TobiasNx referenced this issue in metafacture/metafacture-fix Feb 28, 2022
@TobiasNx
Add integration test for #104
43f36ed 
#160
@TobiasNx TobiasNx mentioned this issue Feb 28, 2022
Merged
@TobiasNx
Copy link
Contributor Author

Has integration test: metafacture/metafacture-fix@43f36ed

@blackwinter
Copy link
Member

Integration test:

@blackwinter blackwinter transferred this issue from metafacture/metafacture-fix Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsteeg fsteeg

Labels
Conform To Catmandu Metafix
Projects
Metafacture
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blackwinter @fsteeg @TobiasNx