Skip to content
This repository has been archived by the owner on Jan 27, 2025. It is now read-only.

do list does not work properly with path wildcards #119

Closed
TobiasNx opened this issue Jan 31, 2022 · 7 comments · Fixed by #142
Closed

do list does not work properly with path wildcards #119

TobiasNx opened this issue Jan 31, 2022 · 7 comments · Fixed by #142
Assignees
@blackwinter

Comments

@TobiasNx
Copy link
Collaborator

TobiasNx commented Jan 31, 2022 •
edited
Loading

See here

Should be:

{
  "coll" : [ {
    "feldtest" : "true",
    "a" : "Dog"
  },{
    "feldtest" : "true",
    "a" : "Ape"
  },{
    "feldtest" : "true",
    "a" : "Giraffe"
  }, {
    "feldtest" : "true",
    "a" : "Crocodile"
  },
 {
    "feldtest" : "true",
    "a" : "Human"
  },
 {
    "feldtest" : "true",
    "a" : "Bird"
  }
 ]
}
@TobiasNx TobiasNx changed the title do do list does not work properly Jan 31, 2022
TobiasNx added a commit to TobiasNx/fix-FunctionalReview-Testing that referenced this issue Jan 31, 2022
@TobiasNx
To do list-test
67375bf 
metafacture/metafacture-fix#119
@TobiasNx
Copy link
Collaborator Author

do list-Test: TobiasNx/fix-FunctionalReview-Testing@67375bf

@blackwinter blackwinter changed the title do list does not work properly do list does not work properly with path wildcards Jan 31, 2022
This was referenced Jan 31, 2022
Closed
Closed
blackwinter added a commit that referenced this issue Feb 2, 2022
@blackwinter
Add unit tests for list bind with path wildcards. (#119)
80f7bd3
@blackwinter
Copy link
Member

Turned example into unit test.

@fsteeg
Copy link
Member

fsteeg commented Feb 3, 2022

Functional review: @TobiasNx
Code review: @fsteeg

@fsteeg fsteeg moved this to Ready in Metafacture Feb 3, 2022
TobiasNx added a commit to TobiasNx/fix-FunctionalReview-Testing that referenced this issue Feb 8, 2022
@TobiasNx
Added another test for do list and changed names
3dd8f97 
Related to:
metafacture/metafacture-fix#115 (comment)

metafacture/metafacture-fix#119
@TobiasNx
Copy link
Collaborator Author

TobiasNx commented Feb 8, 2022

This does also not work with pipes.

@TobiasNx TobiasNx changed the title do list does not work properly with path wildcards do list does not work properly with path wildcards Feb 8, 2022
blackwinter added a commit that referenced this issue Feb 10, 2022
@blackwinter
Fix path wildcards in combination with arrays. (#115, #119)
a0f1187 
Previously, when a wildcard matched multiple fields of which at least one was an array, `Hash.get()` returned a nested array (e.g., `[[Mary, University], Max]`).

Now, matched arrays are flattened (i.e., `[Mary, University, Max]`).
@blackwinter blackwinter mentioned this issue Feb 10, 2022
Merged
@blackwinter blackwinter linked a pull request Feb 10, 2022 that will close this issue
Fix path wildcards in combination with arrays. #142
Merged
@blackwinter blackwinter moved this from Ready to Review in Metafacture Feb 10, 2022
@blackwinter blackwinter removed their assignment Feb 10, 2022
@TobiasNx
Copy link
Collaborator Author

With the new changes pipes do seem to work now. +1 For that .

https://github.com/TobiasNx/fix-FunctionalReview-Testing/blob/5a064c36df1d4342446f0a01c2210089246abe44/data/testing/doList

But the changes in https://github.com/TobiasNx/fix-FunctionalReview-Testing/blob/5a064c36df1d4342446f0a01c2210089246abe44/data/approved/wildCardTest
are irritating.

@blackwinter
Copy link
Member

But the changes in [...] are irritating.

See discussion in #142.

@blackwinter
Copy link
Member

@TobiasNx approved in #142 (comment).

@blackwinter blackwinter assigned blackwinter and unassigned TobiasNx Feb 14, 2022
Repository owner moved this from Review to Done in Metafacture Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@blackwinter blackwinter

Labels
None yet
Projects
Metafacture
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix path wildcards in combination with arrays. metafacture/metafacture-fix
3 participants
@blackwinter @fsteeg @TobiasNx