Skip to content
This repository has been archived by the owner on Jan 27, 2025. It is now read-only.

Add delete:-Attribute to lookup and change the default filter-modus to an optional configuration #149

Closed
TobiasNx opened this issue Feb 14, 2022 · 4 comments
Closed

Add delete:-Attribute to lookup and change the default filter-modus to an optional configuration #149

TobiasNx opened this issue Feb 14, 2022 · 4 comments
Assignees
@fsteeg

Comments

@TobiasNx
Copy link
Collaborator

In contrast to Catmandu lookup in metafacture fix is by default a filter.

Catmandu in contrast has the attribute delete::

lookup(color2,”lookup.csv”,delete:1)
@blackwinter
Copy link
Member

blackwinter commented Feb 14, 2022 •
edited
Loading

See Catmandu::Fix::lookup test.

TobiasNx added a commit that referenced this issue Mar 1, 2022
@TobiasNx
Add integration test for #149
5f52fb8 
Lookup related
@TobiasNx TobiasNx mentioned this issue Mar 1, 2022
Merged
fsteeg added a commit that referenced this issue Mar 4, 2022
@fsteeg
Update passing integration tests (#102, #92, #121, #149, #155)
61e3748
fsteeg added a commit that referenced this issue Mar 4, 2022
@fsteeg
Tweak lookup behavior, partial delete support (#102, #149)
e9dd4ab
@blackwinter blackwinter mentioned this issue Mar 10, 2022
Merged
fsteeg added a commit that referenced this issue Mar 10, 2022
@fsteeg @blackwinter
Handle null results directly in transform (#102, #149, #170)
238e840 
Co-authored-by: Jens Wille <[email protected]>
fsteeg added a commit that referenced this issue Mar 10, 2022
@fsteeg
Remove unnecessary parens, add unit test (#102, #149, #170)
006e3ac
@blackwinter blackwinter mentioned this issue Mar 22, 2022
Merged
fsteeg added a commit that referenced this issue Mar 22, 2022
@fsteeg
Update passing integration tests (#102, #149, #170)
e027e1c
@TobiasNx
Copy link
Collaborator Author

TobiasNx commented Jul 5, 2022

@fsteeg can this be closed?

@blackwinter
Copy link
Member

AFAICS, should have been closed by #170 (e9dd4ab).

@fsteeg fsteeg closed this as completed Jul 5, 2022
@fsteeg fsteeg moved this to Done in Metafacture Jul 5, 2022
@blackwinter
Copy link
Member

Pending integration test:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fsteeg fsteeg

Labels
None yet
Projects
Metafacture
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blackwinter @fsteeg @TobiasNx