Skip to content
This repository has been archived by the owner on Jan 27, 2025. It is now read-only.

Create a Record class that wraps the Map<String, Object> #64

Closed
fsteeg opened this issue Nov 5, 2021 · 2 comments · Fixed by #72
Closed

Create a Record class that wraps the Map<String, Object> #64

fsteeg opened this issue Nov 5, 2021 · 2 comments · Fixed by #72
Assignees
@blackwinter

Comments

@fsteeg
Copy link
Member

fsteeg commented Nov 5, 2021

Came up in #60 (review).
@fsteeg fsteeg mentioned this issue Nov 5, 2021
Merged
@blackwinter
Copy link
Member

Copying previous discussion for better overview:

I would suggest to create a Record class that wraps the Map<String, Object> instead of "littering" Metafix and FixMethod with static methods. But that can happen later. (Maybe it would be an opportunity for me to get more acquainted with the new code.)

Originally posted by @blackwinter in #60 (review)

@fsteeg
Copy link
Member Author

fsteeg commented Nov 10, 2021

No functional review (refactoring), code review: @fsteeg

blackwinter added a commit that referenced this issue Nov 12, 2021
@blackwinter
Initial implementation of Record class. (#64)
ccc47cb 
Still exposes internal map during transitional period.
blackwinter added a commit that referenced this issue Nov 12, 2021
@blackwinter
Introduce Mapping abstraction. (#64)
b89bc1d 
Intended as a shared type for records and map values.
blackwinter added a commit that referenced this issue Nov 12, 2021
@blackwinter
Switch record map values to Mapping. (#64)
605f116 
Thus no longer exposing internal map.
@blackwinter blackwinter mentioned this issue Nov 12, 2021
Merged
blackwinter added a commit that referenced this issue Nov 15, 2021
@blackwinter
Initial implementation of Record class. (#64)
e4d8a47 
Still exposes internal map during transitional period.
blackwinter added a commit that referenced this issue Nov 15, 2021
@blackwinter
Introduce Mapping abstraction. (#64)
8eb5900 
Intended as a shared type for records and map values.
blackwinter added a commit that referenced this issue Nov 15, 2021
@blackwinter
Switch record map values to Mapping. (#64)
77bb545 
Thus no longer exposing internal map.
blackwinter added a commit that referenced this issue Nov 15, 2021
@blackwinter
Move Mapping to Value.Hash. (#64)
c6e20f9 
In preparation of introducing a shared type for record values.
blackwinter added a commit that referenced this issue Nov 16, 2021
@blackwinter
Introduce type-safe record value abstraction. (#64)
dc8c708 
Obviates the need for `instanceof` checks and unchecked casts.

A `Value` is a container/wrapper for either

- an `Array` (which in turn is a wrapper for `List<Value>`), or
- a `Hash` (which in turn is a wrapper for `Map<String, Value>`), or
- a `String` (which is the terminal type)
blackwinter added a commit that referenced this issue Nov 16, 2021
@blackwinter
Move static record/hash methods to Value/Hash class. (#64)
73a0563
blackwinter added a commit that referenced this issue Nov 16, 2021
@blackwinter
Introduce type-safe record value abstraction. (#64)
eebe562 
Obviates the need for `instanceof` checks and unchecked casts.

A `Value` is a container/wrapper for either

- an `Array` (which in turn is a wrapper for `List<Value>`), or
- a `Hash` (which in turn is a wrapper for `Map<String, Value>`), or
- a `String` (which is the terminal type)
blackwinter added a commit that referenced this issue Nov 16, 2021
@blackwinter
Move static record/hash methods to Value/Hash class. (#64)
3e9fde6
blackwinter added a commit that referenced this issue Nov 16, 2021
@blackwinter
Move static record/hash methods to Value/Hash class. (#64)
2d41051
blackwinter added a commit that referenced this issue Nov 16, 2021
@blackwinter
Move static record/hash methods to Value/Hash class. (#64)
28aecba
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@blackwinter blackwinter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce Record class. metafacture/metafacture-fix
2 participants
@blackwinter @fsteeg