-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect & add more Playground examples #25
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
MarcXML as file in web -> JSON (does not need any as-lines or as-record) |
JSON -> JSON with small FIX (but needs newer version of FIX, since it cannot process wildcards in path's) Should come back to this example. |
As an idea for a simple, yet configurable integration in the playground UI: Provide each sample in a text file, load files in playground to populate 'Load sample' drop down with examples, using file name of the text file, e.g. marc_to_json. Examples can then be configured / maintained by adding / editing these text files. |
OAI-PMH - MODS -> JSON: (could be a little nicer since the OAI PMH specific metadata is carried around.) |
As a naming convention for the example files, maybe we could use something like |
Deployed to https://test.metafacture.org/playground/ |
@TobiasNx I installed again to https://test.metafacture.org/playground/ with these changes:
AFter loading a new example, the result box is cleared now.
Yes, you found a bug! I fixed this.
I did not implement something for this. Where and when do you think is the best place for such a tooltip? I am not really sure, how to solve this. If we need this explained, we maybe need also explained how to use the fix and morph editor? |
+1 Now it seems to work. Are they too old?
|
@TobiasNx workflow seems fine - at least it is processed when executed with |
Deployed the fix (metafacture/metafacture-core#435) to test: http://test.lobid.org/playground/. |
Note: changed metafacture-core-dependencies at productive server in |
@TobiasNx in the output the marc record's attribute |
As I stated here: metafacture/metafacture-core#402 (comment) type is optional: https://www.loc.gov/standards/marcxml/xml/spy/spy.html#element_record_Link044CBAB8 Since it is not mandatory we do not need to do this, but we would need to add this as part of the morph. |
Please re-review after functinal changes in code review @TobiasNx |
+1 |
Small examples with different source and target formats, e.g. MARC-to-JSON, JSON-to-JSON, HTML-to-JSON.
We can discuss these with Playground links here in the ticket.
Functional reviewer: @TobiasNx
Code reviewer: @fsteeg
The text was updated successfully, but these errors were encountered: