-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximize URL length for sharing workflows #80
Comments
The current status of this issue (on branch 80-maximizeUrlLength):
I hope this information helps to finish what I couldn't finish. |
The current state looks good and seems to work well with larger examples, see the (work in progress) workshop examples deployed at https://test.metafacture.org/playground/ (Load Examples -> workshop). Using string compression was just an additional idea, I suggest we skip that for now. Regarding the issues with longer links and URLs, I think we should look into that when it comes up in a concrete use case. For now, this is a big step forward to creating useful examples for the workshop and beyond, so I think we should merge and deploy that state to production. Assigning @TobiasNx for functional review. |
The examples look good. It seems that the changes helped with longer URLs/examples. |
Merged 80-maximizeUrlLength with fafc143. Deployed to https://metafacture.org/playground, closing. |
Look into possible string compression algorithms to use on the query paramsFunctional review: @TobiasNx
Code review: @fsteeg
The text was updated successfully, but these errors were encountered: