Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOL file bond types aromatic single (6) and aromatic double (7) not recognized #2

Open
BobHanson opened this issue Mar 9, 2016 · 4 comments

Comments

@BobHanson
Copy link

MOL files created using some software use the "single or aromatic" (6) and "double or aromatic" (7) bond types as described in http://accelrys.com/products/informatics/cheminformatics/ctfile-formats/no-fee.php

The presence of these bond types causes a loading error:

Molfile is invalid.

But these would be easily interpreted as "single" and "double", respectively. Suggestion is to read bond type 6 as single and bond type 7 as double

@rapodaca
Copy link
Collaborator

rapodaca commented Mar 9, 2016

The error is propagating from InChI itself, which returns a molecule with no atoms:

https://github.com/metamolecular/inchi-js/blob/master/src/inchi.c#L34

The aromatic bond are only valid for queries. As the CTfile Formats documentation states in the Bond Block table:

Types 4 through 8 are for queries only.

@BobHanson
Copy link
Author

Isn't a lot of what this is about "queries"? I understand you are saying
that is more of a "SMARTS" version of a mol file, not SMILES. But they do
exist, and it seems to me a very simple request.

On Wed, Mar 9, 2016 at 12:22 PM, Richard Apodaca [email protected]
wrote:

The error is propagating from InChI itself, which returns a molecule with
no atoms:

https://github.com/metamolecular/inchi-js/blob/master/src/inchi.c#L34

The aromatic bond are only valid for queries. As the CTfile Formats
documentation states in the Bond Block table:

Types 4 through 8 are for queries only.


Reply to this email directly or view it on GitHub
#2 (comment)
.

Robert M. Hanson
Larson-Anderson Professor of Chemistry
Chair, Department of Chemistry
St. Olaf College
Northfield, MN
http://www.stolaf.edu/people/hansonr

If nature does not answer first what we want,
it is better to take what answer we get.

-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900

@rapodaca
Copy link
Collaborator

rapodaca commented Mar 9, 2016

Although the request is simple, the solution is not.

InChI.js is the actual InChI C library, compiled to JavaScript. The C file I linked is a thin wrapper that the JavaScript runtime communicates with. All InChI.js is doing is handling an error propagated from the InChI C library.

The InChI team might be in a position to address your request, though.

@BobHanson
Copy link
Author

Sure, that makes sense. OK.

On Wed, Mar 9, 2016 at 1:12 PM, Richard Apodaca [email protected]
wrote:

Although the request is simple, the solution is not.

InChI.js is the actual InChI C library, compiled to JavaScript. The C file
I linked is a thin wrapper that the JavaScript runtime communicates with.
All InChI.js is doing is handling an error propagated from the InChI C
library.

The InChI team might be in a position to address your request, though.


Reply to this email directly or view it on GitHub
#2 (comment)
.

Robert M. Hanson
Larson-Anderson Professor of Chemistry
Chair, Department of Chemistry
St. Olaf College
Northfield, MN
http://www.stolaf.edu/people/hansonr

If nature does not answer first what we want,
it is better to take what answer we get.

-- Josiah Willard Gibbs, Lecture XXX, Monday, February 5, 1900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants