Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight can't be zero #49

Closed
danielkza opened this issue Aug 20, 2015 · 2 comments
Closed

Weight can't be zero #49

danielkza opened this issue Aug 20, 2015 · 2 comments
Labels

Comments

@danielkza
Copy link
Contributor

Can't we redefine this validation? In some cases, having weight equal to zero may be useful.
For example, the blank lines metric from Radon, since it does not have any meaning by itself. Is only means something when compared to the total number of lines. Therefore, assigning a range for it may be confusing.

@rafamanzo
Copy link
Member

Agreed. We need a special case for MetricConfiguration: #52

(blank lines are good in python? I think that in excess they make the maintenability harder)

@danielkza
Copy link
Contributor Author

I don't think they're particularly good or bad, but having at least a fraction of your code be blank lines means you probably have at least reasonable layout and separation between methods, classes, etc. For example, having 10 blank lines for 1000 code lines probably means something is a bit wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants