Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong refresh behaviour for repository show page #250

Open
rafamanzo opened this issue Jul 14, 2015 · 1 comment
Open

Wrong refresh behaviour for repository show page #250

rafamanzo opened this issue Jul 14, 2015 · 1 comment
Labels

Comments

@rafamanzo
Copy link
Member

If you have selected a module in the tree and refresh the whole page, the loaded page won't be at the selected module but back to the root. The same happens if you select a processing by date.

One way to fix this would be to make the module id and processing id part of the route.

@rafamanzo rafamanzo added the bug label Jul 14, 2015
@diegoamc
Copy link
Contributor

diegoamc commented Nov 9, 2015

When refreshing the page, adding the module id and the processing id on the route should solve the problem.

But when selecting a processing by date the situation is more subtle because the module may not exist on different times of the same project. Also, the processing id is different and we cannot guarantee that the module will have the same id.

We could search for the module name, but even then the module may not exist on the selected date.

For that case, I think the best approach is to simply go back to the root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants